public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec'
@ 2024-05-17 23:26 linux
  2024-06-03 17:30 ` Dr. David Alan Gilbert
  2024-06-11 10:02 ` Danilo Krummrich
  0 siblings, 2 replies; 5+ messages in thread
From: linux @ 2024-05-17 23:26 UTC (permalink / raw)
  To: kherbst, lyude
  Cc: daniel, nouveau, dri-devel, linux-kernel, Dr. David Alan Gilbert

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'init_exec' is unused since
commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new
init table parser")
Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/gpu/drm/nouveau/nouveau_bios.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
index 79cfab53f80e..8c3c1f1e01c5 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bios.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
@@ -43,11 +43,6 @@
 #define BIOSLOG(sip, fmt, arg...) NV_DEBUG(sip->dev, fmt, ##arg)
 #define LOG_OLD_VALUE(x)
 
-struct init_exec {
-	bool execute;
-	bool repeat;
-};
-
 static bool nv_cksum(const uint8_t *data, unsigned int length)
 {
 	/*
-- 
2.45.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec'
  2024-05-17 23:26 [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec' linux
@ 2024-06-03 17:30 ` Dr. David Alan Gilbert
  2024-06-11 10:02 ` Danilo Krummrich
  1 sibling, 0 replies; 5+ messages in thread
From: Dr. David Alan Gilbert @ 2024-06-03 17:30 UTC (permalink / raw)
  To: kherbst, lyude, dakr; +Cc: bskeggs, daniel, nouveau, dri-devel, linux-kernel

* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'init_exec' is unused since
> commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new
> init table parser")
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Ping.


> ---
>  drivers/gpu/drm/nouveau/nouveau_bios.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
> index 79cfab53f80e..8c3c1f1e01c5 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
> @@ -43,11 +43,6 @@
>  #define BIOSLOG(sip, fmt, arg...) NV_DEBUG(sip->dev, fmt, ##arg)
>  #define LOG_OLD_VALUE(x)
>  
> -struct init_exec {
> -	bool execute;
> -	bool repeat;
> -};
> -
>  static bool nv_cksum(const uint8_t *data, unsigned int length)
>  {
>  	/*
> -- 
> 2.45.1
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec'
  2024-05-17 23:26 [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec' linux
  2024-06-03 17:30 ` Dr. David Alan Gilbert
@ 2024-06-11 10:02 ` Danilo Krummrich
  2024-06-11 10:37   ` Dr. David Alan Gilbert
  1 sibling, 1 reply; 5+ messages in thread
From: Danilo Krummrich @ 2024-06-11 10:02 UTC (permalink / raw)
  To: linux; +Cc: daniel, nouveau, dri-devel, linux-kernel, kherbst, lyude

On 5/18/24 01:26, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'init_exec' is unused since
> commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new
> init table parser")
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Acked-by: Danilo Krummrich <dakr@redhat.com>

To which series does this patch belong? Need me to apply it?

- Danilo

> ---
>   drivers/gpu/drm/nouveau/nouveau_bios.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
> index 79cfab53f80e..8c3c1f1e01c5 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
> @@ -43,11 +43,6 @@
>   #define BIOSLOG(sip, fmt, arg...) NV_DEBUG(sip->dev, fmt, ##arg)
>   #define LOG_OLD_VALUE(x)
>   
> -struct init_exec {
> -	bool execute;
> -	bool repeat;
> -};
> -
>   static bool nv_cksum(const uint8_t *data, unsigned int length)
>   {
>   	/*


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec'
  2024-06-11 10:02 ` Danilo Krummrich
@ 2024-06-11 10:37   ` Dr. David Alan Gilbert
  2024-06-11 21:24     ` Danilo Krummrich
  0 siblings, 1 reply; 5+ messages in thread
From: Dr. David Alan Gilbert @ 2024-06-11 10:37 UTC (permalink / raw)
  To: Danilo Krummrich; +Cc: daniel, nouveau, dri-devel, linux-kernel, kherbst, lyude

* Danilo Krummrich (dakr@redhat.com) wrote:
> On 5/18/24 01:26, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > 'init_exec' is unused since
> > commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new
> > init table parser")
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> 
> Acked-by: Danilo Krummrich <dakr@redhat.com>
> 
> To which series does this patch belong?

Actually all of them were independent patches on drm
some of which are all in, so it can be taken by itself.

> Need me to apply it?

Yes please!

Thanks,

Dave

> - Danilo
> 
> > ---
> >   drivers/gpu/drm/nouveau/nouveau_bios.c | 5 -----
> >   1 file changed, 5 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
> > index 79cfab53f80e..8c3c1f1e01c5 100644
> > --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
> > +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
> > @@ -43,11 +43,6 @@
> >   #define BIOSLOG(sip, fmt, arg...) NV_DEBUG(sip->dev, fmt, ##arg)
> >   #define LOG_OLD_VALUE(x)
> > -struct init_exec {
> > -	bool execute;
> > -	bool repeat;
> > -};
> > -
> >   static bool nv_cksum(const uint8_t *data, unsigned int length)
> >   {
> >   	/*
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec'
  2024-06-11 10:37   ` Dr. David Alan Gilbert
@ 2024-06-11 21:24     ` Danilo Krummrich
  0 siblings, 0 replies; 5+ messages in thread
From: Danilo Krummrich @ 2024-06-11 21:24 UTC (permalink / raw)
  To: Dr. David Alan Gilbert
  Cc: daniel, nouveau, dri-devel, linux-kernel, kherbst, lyude

On 6/11/24 12:37, Dr. David Alan Gilbert wrote:
> * Danilo Krummrich (dakr@redhat.com) wrote:
>> On 5/18/24 01:26, linux@treblig.org wrote:
>>> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>>>
>>> 'init_exec' is unused since
>>> commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new
>>> init table parser")
>>> Remove it.
>>>
>>> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>>
>> Acked-by: Danilo Krummrich <dakr@redhat.com>
>>
>> To which series does this patch belong?
> 
> Actually all of them were independent patches on drm
> some of which are all in, so it can be taken by itself.
> 
>> Need me to apply it?
> 
> Yes please!

Applied to drm-misc-fixes, thanks!

> 
> Thanks,
> 
> Dave
> 
>> - Danilo
>>
>>> ---
>>>    drivers/gpu/drm/nouveau/nouveau_bios.c | 5 -----
>>>    1 file changed, 5 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
>>> index 79cfab53f80e..8c3c1f1e01c5 100644
>>> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
>>> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
>>> @@ -43,11 +43,6 @@
>>>    #define BIOSLOG(sip, fmt, arg...) NV_DEBUG(sip->dev, fmt, ##arg)
>>>    #define LOG_OLD_VALUE(x)
>>> -struct init_exec {
>>> -	bool execute;
>>> -	bool repeat;
>>> -};
>>> -
>>>    static bool nv_cksum(const uint8_t *data, unsigned int length)
>>>    {
>>>    	/*
>>


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-06-11 21:24 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-17 23:26 [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec' linux
2024-06-03 17:30 ` Dr. David Alan Gilbert
2024-06-11 10:02 ` Danilo Krummrich
2024-06-11 10:37   ` Dr. David Alan Gilbert
2024-06-11 21:24     ` Danilo Krummrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox