From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Genjian <zhanggenjian@126.com>
Cc: chenhuacai@kernel.org, jiaxun.yang@flygoat.com,
ricardo@marliere.net, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org,
Genjian Zhang <zhanggenjian@kylinos.cn>,
k2ci <kernel-bot@kylinos.cn>
Subject: Re: [PATCH 3/3] MIPS: ip22-gio: Make ip22_gio_set_64bit() and ip22_gio_init() static
Date: Tue, 11 Jun 2024 13:21:54 +0200 [thread overview]
Message-ID: <ZmgzUqORONkQLWoA@alpha.franken.de> (raw)
In-Reply-To: <20240516115906.1224164-3-zhanggenjian@126.com>
On Thu, May 16, 2024 at 07:59:06PM +0800, Genjian wrote:
> From: Genjian Zhang <zhanggenjian@kylinos.cn>
>
> These functions are used in only one file.
> Made them static to fix the following build error:
>
> arch/mips/sgi-ip22/ip22-gio.c:249:6: error: no previous prototype for ‘ip22_gio_set_64bit’ [-Werror=missing-prototypes]
> arch/mips/sgi-ip22/ip22-gio.c:398:12: error: no previous prototype for ‘ip22_gio_init’ [-Werror=missing-prototypes]
>
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn>
> ---
> arch/mips/sgi-ip22/ip22-gio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2024-06-11 12:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 11:59 [PATCH 1/3] MIPS: Loongson64: include asm/bootinfo.h Genjian
2024-05-16 11:59 ` [PATCH 2/3] MIPS: sgi-ip22: Add prototypes for several functions to header Genjian
2024-06-11 11:21 ` Thomas Bogendoerfer
2024-05-16 11:59 ` [PATCH 3/3] MIPS: ip22-gio: Make ip22_gio_set_64bit() and ip22_gio_init() static Genjian
2024-06-11 11:21 ` Thomas Bogendoerfer [this message]
2024-05-16 12:21 ` [PATCH 1/3] MIPS: Loongson64: include asm/bootinfo.h Jiaxun Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmgzUqORONkQLWoA@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=chenhuacai@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel-bot@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=ricardo@marliere.net \
--cc=zhanggenjian@126.com \
--cc=zhanggenjian@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox