From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1FC621DDF4; Tue, 11 Jun 2024 14:14:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.175.24.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718115295; cv=none; b=FEK+/ayTHNL/jWlenb0XGcl7u/p9qwv8rbV8hoL9tPx9ZxERBVBoBP/Ckdjg5rQSgQzihEJJKmYYOKirGSibgYeg8I4Wsl8hWDeuduGIPVyXj87Qov/+UBgtQy3XszM/NQsJ48k8v5J7AL8hbk7NfkjqxctXUCayP0D6Hnjjy/Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718115295; c=relaxed/simple; bh=wQbEJocG3DYWCV/bbjuTe2rWvWiRPGvtjmOpsxe4i7E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=N9vCELntNBJjYje6Z8dvBIcjgmUKTCo66euCjlRpgxTLmNE1SjW1ZN3wJ2WcpDajJJL7iif+zSxtVShxXhvw46h3qdlW3qqozQDGnFVRMx0lSxfQxuIfHVa9WENzmIxlAylFxbxBKjSGn7q6IBxpL+E3Lm22VtHZKgKT76Wg3Tc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de; spf=pass smtp.mailfrom=alpha.franken.de; arc=none smtp.client-ip=193.175.24.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alpha.franken.de Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1sH2Gu-00034I-00; Tue, 11 Jun 2024 16:14:48 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 54997C0411; Tue, 11 Jun 2024 16:12:57 +0200 (CEST) Date: Tue, 11 Jun 2024 16:12:57 +0200 From: Thomas Bogendoerfer To: Christian Marangi Cc: Hauke Mehrtens , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , =?iso-8859-1?Q?=C1lvaro_Fern=E1ndez?= Rojas , linux-mips@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 1/5] mips: bmips: BCM6358: make sure CBR is correctly set Message-ID: References: <20240611113538.9004-1-ansuelsmth@gmail.com> <20240611113538.9004-2-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240611113538.9004-2-ansuelsmth@gmail.com> On Tue, Jun 11, 2024 at 01:35:33PM +0200, Christian Marangi wrote: > It was discovered that some device have CBR address set to 0 causing > kernel panic when arch_sync_dma_for_cpu_all is called. > > This was notice in situation where the system is booted from TP1 and > BMIPS_GET_CBR() returns 0 instead of a valid address and > !!(read_c0_brcm_cmt_local() & (1 << 31)); not failing. > > The current check whether RAC flush should be disabled or not are not > enough hence lets check if CBR is a valid address or not. > > Fixes: ab327f8acdf8 ("mips: bmips: BCM6358: disable RAC flush for TP1") > Signed-off-by: Christian Marangi > Acked-by: Florian Fainelli > --- > arch/mips/bmips/setup.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) applied to mips-fixes. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]