Re: [PATCH] dmaengine: ti: k3-udma-glue: Fix of_k3_udma_glue_parse_chn_by_id()

Péter Ujfalusi
2024-05-21T14:43:39Z

On 18/05/2024 13:05, Siddharth Vadapalli wrote:
> The of_k3_udma_glue_parse_chn_by_id() helper function erroneously
> invokes "of_node_put()" on the "udmax_np" device-node passed to it,
> without having incremented its reference at any point. Fix it.

Acked-by: Peter Ujfalusi@gmail.com

>
> Fixes: 81a1f90f20af ("dmaengine: ti: k3-udma-glue: Add function to parse channel by ID")
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> ---
>
> Hello,
>
> This patch is based on commit
> 4b377b4868ef kprobe/ftrace: fix build error due to bad function definition
> of Mainline Linux.
>
> Regards,
> Siddharth.
>
> drivers/dma/ti/k3-udma-glue.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma/ti/k3-udma-glue.c
> index c9b93055dc9d..f0a399cf45b2 100644
> --- a/drivers/dma/ti/k3-udma-glue.c
> +++ b/drivers/dma/ti/k3-udma-glue.c
> @@ -200,12 +200,9 @@ of_k3_udma_glue_parse_chn_by_id(struct device_node *udmax_np, struct k3_udma_glu
>
> ret = of_k3_udma_glue_parse(udmax_np, common);
> if (ret)
> - goto out_put_spec;
> + return ret;
>
> ret = of_k3_udma_glue_parse_chn_common(common, thread_id, tx_chn);
> -
> -out_put_spec:
> - of_node_put(udmax_np);
> return ret;
> }
>

--
Péter