Re: [RFC net-next v4 0/2] mlx5: Add netdev-genl queue stats

Jakub Kicinski
2024-06-06T16:23:55Z

On Tue, 4 Jun 2024 00:46:24 +0000 Joe Damato wrote:
> Significant rewrite from v3 and hopefully getting closer to correctly
> exporting per queue stats from mlx5. Please see changelog below for
> detailed changes, especially regarding PTP stats.
>
> Note that my NIC does not seem to support PTP and I couldn't get the
> mlnx-tools mlnx_qos script to work, so I was only able to test the
> following cases:
>
> - device up at booot
> - adjusting queue counts
> - device down (e.g. ip link set dev eth4 down)
>
> Please see the commit message of patch 2/2 for more details on output
> and test cases.

nvidia, please review this

It's less than 200 lines of code, and every time Joe posts a new
version he has to wait a week to get feedback.