* [PATCH] rapidio: removse some dead defines
@ 2024-05-28 0:25 linux
2024-06-13 13:26 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 3+ messages in thread
From: linux @ 2024-05-28 0:25 UTC (permalink / raw)
To: mporter, alex.bou9; +Cc: linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
'mport_dma_buf', 'rio_mport_dma_map' and 'MPORT_MAX_DMA_BUFS' were
added in the original
commit e8de370188d0 ("rapidio: add mport char device driver")
but never used.
'rio_cm_work' was unused since the original
commit b6e8d4aa1110 ("rapidio: add RapidIO channelized messaging
driver")
but never used.
Remove them.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/rapidio/devices/rio_mport_cdev.c | 20 --------------------
drivers/rapidio/rio_cm.c | 6 ------
2 files changed, 26 deletions(-)
diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
index 27afbb9d544b..5c83741c3005 100644
--- a/drivers/rapidio/devices/rio_mport_cdev.c
+++ b/drivers/rapidio/devices/rio_mport_cdev.c
@@ -97,18 +97,6 @@ module_param(dbg_level, uint, S_IWUSR | S_IWGRP | S_IRUGO);
MODULE_PARM_DESC(dbg_level, "Debugging output level (default 0 = none)");
#endif
-/*
- * An internal DMA coherent buffer
- */
-struct mport_dma_buf {
- void *ib_base;
- dma_addr_t ib_phys;
- u32 ib_size;
- u64 ib_rio_base;
- bool ib_map;
- struct file *filp;
-};
-
/*
* Internal memory mapping structure
*/
@@ -131,14 +119,6 @@ struct rio_mport_mapping {
struct file *filp;
};
-struct rio_mport_dma_map {
- int valid;
- u64 length;
- void *vaddr;
- dma_addr_t paddr;
-};
-
-#define MPORT_MAX_DMA_BUFS 16
#define MPORT_EVENT_DEPTH 10
/*
diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c
index 9135227301c8..97287e838ce1 100644
--- a/drivers/rapidio/rio_cm.c
+++ b/drivers/rapidio/rio_cm.c
@@ -198,12 +198,6 @@ struct cm_peer {
struct rio_dev *rdev;
};
-struct rio_cm_work {
- struct work_struct work;
- struct cm_dev *cm;
- void *data;
-};
-
struct conn_req {
struct list_head node;
u32 destid; /* requester destID */
--
2.45.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] rapidio: removse some dead defines
2024-05-28 0:25 [PATCH] rapidio: removse some dead defines linux
@ 2024-06-13 13:26 ` Dr. David Alan Gilbert
2024-07-05 1:36 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2024-06-13 13:26 UTC (permalink / raw)
To: mporter, alex.bou9; +Cc: linux-kernel
* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'mport_dma_buf', 'rio_mport_dma_map' and 'MPORT_MAX_DMA_BUFS' were
> added in the original
> commit e8de370188d0 ("rapidio: add mport char device driver")
> but never used.
>
> 'rio_cm_work' was unused since the original
> commit b6e8d4aa1110 ("rapidio: add RapidIO channelized messaging
> driver")
> but never used.
>
> Remove them.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Ping?
Dave
> ---
> drivers/rapidio/devices/rio_mport_cdev.c | 20 --------------------
> drivers/rapidio/rio_cm.c | 6 ------
> 2 files changed, 26 deletions(-)
>
> diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
> index 27afbb9d544b..5c83741c3005 100644
> --- a/drivers/rapidio/devices/rio_mport_cdev.c
> +++ b/drivers/rapidio/devices/rio_mport_cdev.c
> @@ -97,18 +97,6 @@ module_param(dbg_level, uint, S_IWUSR | S_IWGRP | S_IRUGO);
> MODULE_PARM_DESC(dbg_level, "Debugging output level (default 0 = none)");
> #endif
>
> -/*
> - * An internal DMA coherent buffer
> - */
> -struct mport_dma_buf {
> - void *ib_base;
> - dma_addr_t ib_phys;
> - u32 ib_size;
> - u64 ib_rio_base;
> - bool ib_map;
> - struct file *filp;
> -};
> -
> /*
> * Internal memory mapping structure
> */
> @@ -131,14 +119,6 @@ struct rio_mport_mapping {
> struct file *filp;
> };
>
> -struct rio_mport_dma_map {
> - int valid;
> - u64 length;
> - void *vaddr;
> - dma_addr_t paddr;
> -};
> -
> -#define MPORT_MAX_DMA_BUFS 16
> #define MPORT_EVENT_DEPTH 10
>
> /*
> diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c
> index 9135227301c8..97287e838ce1 100644
> --- a/drivers/rapidio/rio_cm.c
> +++ b/drivers/rapidio/rio_cm.c
> @@ -198,12 +198,6 @@ struct cm_peer {
> struct rio_dev *rdev;
> };
>
> -struct rio_cm_work {
> - struct work_struct work;
> - struct cm_dev *cm;
> - void *data;
> -};
> -
> struct conn_req {
> struct list_head node;
> u32 destid; /* requester destID */
> --
> 2.45.1
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] rapidio: removse some dead defines
2024-06-13 13:26 ` Dr. David Alan Gilbert
@ 2024-07-05 1:36 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2024-07-05 1:36 UTC (permalink / raw)
To: mporter, alex.bou9; +Cc: linux-kernel, rdunlap
* Dr. David Alan Gilbert (linux@treblig.org) wrote:
> * linux@treblig.org (linux@treblig.org) wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > 'mport_dma_buf', 'rio_mport_dma_map' and 'MPORT_MAX_DMA_BUFS' were
> > added in the original
> > commit e8de370188d0 ("rapidio: add mport char device driver")
> > but never used.
> >
> > 'rio_cm_work' was unused since the original
> > commit b6e8d4aa1110 ("rapidio: add RapidIO channelized messaging
> > driver")
> > but never used.
> >
> > Remove them.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>
> Ping?
Ping^2
> Dave
>
> > ---
> > drivers/rapidio/devices/rio_mport_cdev.c | 20 --------------------
> > drivers/rapidio/rio_cm.c | 6 ------
> > 2 files changed, 26 deletions(-)
> >
> > diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
> > index 27afbb9d544b..5c83741c3005 100644
> > --- a/drivers/rapidio/devices/rio_mport_cdev.c
> > +++ b/drivers/rapidio/devices/rio_mport_cdev.c
> > @@ -97,18 +97,6 @@ module_param(dbg_level, uint, S_IWUSR | S_IWGRP | S_IRUGO);
> > MODULE_PARM_DESC(dbg_level, "Debugging output level (default 0 = none)");
> > #endif
> >
> > -/*
> > - * An internal DMA coherent buffer
> > - */
> > -struct mport_dma_buf {
> > - void *ib_base;
> > - dma_addr_t ib_phys;
> > - u32 ib_size;
> > - u64 ib_rio_base;
> > - bool ib_map;
> > - struct file *filp;
> > -};
> > -
> > /*
> > * Internal memory mapping structure
> > */
> > @@ -131,14 +119,6 @@ struct rio_mport_mapping {
> > struct file *filp;
> > };
> >
> > -struct rio_mport_dma_map {
> > - int valid;
> > - u64 length;
> > - void *vaddr;
> > - dma_addr_t paddr;
> > -};
> > -
> > -#define MPORT_MAX_DMA_BUFS 16
> > #define MPORT_EVENT_DEPTH 10
> >
> > /*
> > diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c
> > index 9135227301c8..97287e838ce1 100644
> > --- a/drivers/rapidio/rio_cm.c
> > +++ b/drivers/rapidio/rio_cm.c
> > @@ -198,12 +198,6 @@ struct cm_peer {
> > struct rio_dev *rdev;
> > };
> >
> > -struct rio_cm_work {
> > - struct work_struct work;
> > - struct cm_dev *cm;
> > - void *data;
> > -};
> > -
> > struct conn_req {
> > struct list_head node;
> > u32 destid; /* requester destID */
> > --
> > 2.45.1
> >
> --
> -----Open up your eyes, open up your mind, open up your code -------
> / Dr. David Alan Gilbert | Running GNU/Linux | Happy \
> \ dave @ treblig.org | | In Hex /
> \ _________________________|_____ http://www.treblig.org |_______/
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-05 1:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-28 0:25 [PATCH] rapidio: removse some dead defines linux
2024-06-13 13:26 ` Dr. David Alan Gilbert
2024-07-05 1:36 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox