From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35CD61420D0 for ; Fri, 28 Jun 2024 07:45:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719560725; cv=none; b=SML63J/Bwymmxn1VYOT6ePdGUQmlbeJXn4zIjl4NtmcZ1m2Xv3KaGlU6XPE2A9MyHNDya3Zn6f01QnM8s2ma8TxzyGRDuXQ9FD2mhEiXknJB8YxI3jl7Y9Rhige0nnBh/iyjAa9Bie4C4afrvcvzXJd+UFQe/FOcKTp5U6R27Sc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719560725; c=relaxed/simple; bh=JUSBkqtlFZlGM2xrcHSRfAoIIHT2J2BMiHSuf0F3BaQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=roW5l2KWrCRLS8572uS8aqZoBDbCOQN8Q/x5xraZNaeyOsPVASJENJfWZRVPpbDO6w1Mk3yPSd89jg8z7tVqkd0k7zdA3tY3ruUHZGTEOGItibD8VERqmA2UUB7r8lX5SFnbZXzcocNmpbstvflYBS1nvwcSGIGDh5phTRkB7GA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=cBik3OzG; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="cBik3OzG" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-57d1782679fso380638a12.0 for ; Fri, 28 Jun 2024 00:45:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1719560721; x=1720165521; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zK0IyvrzgL+xOXZeNs6NwkiIfLaj+g1X1XQRxC3Lni0=; b=cBik3OzGJhPIfXH8ZDw6Rsg6uKBh2TKOAnZJdhIkhmOREobaEpOkdYKA3wilgcsmry TV3PTsM094JRHfmM9GjObGYRWFQNf/WPsRBpESm5aWg879Nrx9qodMZWV6Kk6YjNgBlh Z1WeQhQYfjEDwwQ2xf58mkxBop9MdC/JtAeT+sMPsmtp6GvTD24tYljAlmKcnbcnwZln VQxebrsW+iPlz0N3qXWXdRpbZNUHC72939tIz97Ssg89coFNTbEWYoHrUr0xSXyaHHRg HWtl925Qv169EZcVIx1f6L4C9oJNx68jIdicHLNEcuByKEfk+wLn5x/nyGqXVDgMyWLa G6Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719560721; x=1720165521; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zK0IyvrzgL+xOXZeNs6NwkiIfLaj+g1X1XQRxC3Lni0=; b=STH8o+ljC620lwxkwdNvAPPH1+YNz/PXjEhRCv+z+ehUZMjsrRt6Q+eBOTMWyzDA3U h2g0tgUSdK1zwP5i4oeZGtZf7oorEJzlkF6EDogEL/qtRsrA3dJ9WSQz7Vzh5yGTETR4 UODbvg7WaAfOluXomWq7ufIKy3KH2rTadSpNLdVg07F01Nqcy5x8lYptOuA+ZFw1qtvB CHdU3b8h/RNW6qSbo5tfLmu+dy+m3iwK0VnQcPVzHsCfqbVAT9zzccl/ppGFFzQi2iA5 hE9x1qrBIoj/QItBCiyVHj7wa3kLJydzvljeeM8t6mvZMAe3e5RH4DoSsYjZTHmp3HWf qsmQ== X-Forwarded-Encrypted: i=1; AJvYcCVAvOSC59aukzg8JDuWssj3LVC0UPnk/BT2Cz37aiOYxSF0arz/4437ZebDVTxbmLUzSoXFqcNg6AvAvejOrqLkzIKUQnxau/tCFPah X-Gm-Message-State: AOJu0Yz5HbFxop1XItlVysVKZfmDCZTQUb+SM2TdT6+8SEFvwrvopNVK V5d9Ow3kRbk9S/+DR7dcB9GbnDfJ757VryGHVUSzyc0S8ugTBI9DBr+HuLvTLko= X-Google-Smtp-Source: AGHT+IFbVaxM0DAkYtocL0zgPx+w3Uad0KAy3J9JWLJJFEoXMfvodZvIMdiV5+OAEx1nZLaxrud7Kw== X-Received: by 2002:a50:cd9e:0:b0:57d:785:7cc2 with SMTP id 4fb4d7f45d1cf-57d4bdcc05bmr9343309a12.28.1719560721489; Fri, 28 Jun 2024 00:45:21 -0700 (PDT) Received: from localhost (109-81-86-16.rct.o2.cz. [109.81.86.16]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5861503b52esm610372a12.89.2024.06.28.00.45.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jun 2024 00:45:21 -0700 (PDT) Date: Fri, 28 Jun 2024 09:45:20 +0200 From: Michal Hocko To: Xiu Jianfeng Cc: hannes@cmpxchg.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mm: memcg: adjust the warning when seq_buf overflows Message-ID: References: <20240628072333.2496527-1-xiujianfeng@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240628072333.2496527-1-xiujianfeng@huawei.com> On Fri 28-06-24 07:23:33, Xiu Jianfeng wrote: > Currently it uses WARN_ON_ONCE() if seq_buf overflows when user reads > memory.stat, the only advantage of WARN_ON_ONCE is that the splat is > so verbose that it gets noticed. And also it panics the system if > panic_on_warn is enabled. It seems like the warning is just an over > reaction and a simple pr_warn should just achieve the similar effect. > > Suggested-by: Michal Hocko > Signed-off-by: Xiu Jianfeng Acked-by: Michal Hocko I would just squash this with other patch removing it from memcg_stat_format. But this is up to you. Thanks! > --- > mm/memcontrol.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index c251bbe35f4b..8e5590ac43d7 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1484,7 +1484,8 @@ static void memory_stat_format(struct mem_cgroup *memcg, struct seq_buf *s) > memcg_stat_format(memcg, s); > else > memcg1_stat_format(memcg, s); > - WARN_ON_ONCE(seq_buf_has_overflowed(s)); > + if (seq_buf_has_overflowed(s)) > + pr_warn("%s: Warning, stat buffer overflow, please report\n", __func__); > } > > /** > -- > 2.34.1 > -- Michal Hocko SUSE Labs