Re: [PATCH 03/10] ARM: pxa/gumstix: convert vbus gpio to use software nodes

Arnd Bergmann
2024-08-06T07:20:21Z

On Fri, Jun 28, 2024, at 20:08, Dmitry Torokhov wrote:
> Switch vbus gpios from using a custom GPIO lookup table to software
> properties using PROPERTY_ENTRY_GPIO() constructs which closely mimic
> device tree gpio properties.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

I ran into some randconfig build failures with this one now:

> index c9f0f62187bd..b9eddc691097 100644
> --- a/arch/arm/mach-pxa/gumstix.c
> +++ b/arch/arm/mach-pxa/gumstix.c
> @@ -100,26 +100,22 @@ static void __init gumstix_mmc_init(void)
> #endif
>
> #ifdef CONFIG_USB_PXA25X
> -static struct gpiod_lookup_table gumstix_gpio_vbus_gpiod_table = {
> - .dev_id = "gpio-vbus",
> - .table = {
> - GPIO_LOOKUP("gpio-pxa", GPIO_GUMSTIX_USB_GPIOn,
> - "vbus", GPIO_ACTIVE_HIGH),
> - GPIO_LOOKUP("gpio-pxa", GPIO_GUMSTIX_USB_GPIOx,
> - "pullup", GPIO_ACTIVE_HIGH),
> - { },
> - },
> +static const struct property_entry spitz_mci_props[] __initconst = {
> + PROPERTY_ENTRY_GPIO("vbus-gpios", &pxa2xx_gpiochip_node,
> + GPIO_GUMSTIX_USB_GPIOn, GPIO_ACTIVE_HIGH),
> + PROPERTY_ENTRY_GPIO("pullup-gpios", &pxa2xx_gpiochip_node,
> + GPIO_GUMSTIX_USB_GPIOx, GPIO_ACTIVE_HIGH),
> + { }
> };
>

This is missing a few #include, the name spitz_mci_props[]
is wrong for this file and the array is not referenced anywhere.

I assume the gumstix_gpio_vbus_info needs to be turned into
an swnode, but I haven't figured out how to do this.

Based on the recent board deprecation discussion, I expect
that there are no users and that we will remove this machine
early next year, so we don't need to care about making it
pretty now, but maybe you can send a patch to make it build
again.

Arnd