From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 109EE15381F for ; Tue, 18 Jun 2024 09:30:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718703023; cv=none; b=Z1U7sWx0ToglIepveo+RweqwkOXTSiMcHS1a1mIKb44l3ZSW4kfTUjDqTlma7ZytsZgmj89fJOQoCKE6fdtySE1IlgaglTpBgqjvEbLOCAH8gETMfygCbQB0F8827rp1UZNLauspcuYAzm/hjShS/yJo7DyGJBR2Km10SLlodeo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718703023; c=relaxed/simple; bh=VpqATmY4KjFpTaddmRIycfLEE2w5IFvvlgBNPkIm9QY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F7CJJdbvg3rr336Nnrb5CJi/bXpaZ6SEW1y4xE3Ad4ZvtQQAjx80F+JkPKWcRaOK5gxE2qmsZblYYvm4QXrNoFmzo1ba5XUZL9uEU+Bt7rCvQEOOYZJmI4cxWBZrVxx1g560b4WrOEMDTH8VxTGINQxN8FLkTi1zvxAlOEvwzug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 909F8DA7; Tue, 18 Jun 2024 02:30:44 -0700 (PDT) Received: from e133344.arm.com (unknown [10.1.33.195]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 611723F64C; Tue, 18 Jun 2024 02:30:15 -0700 (PDT) Date: Tue, 18 Jun 2024 10:30:07 +0100 From: Dave Martin To: Reinette Chatre Cc: x86@kernel.org, linux-kernel@vger.kernel.org, James Morse , Fenghua Yu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Babu Moger , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, "Shaopeng Tan (Fujitsu)" , baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , Peter Newman , dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Rex Nie Subject: Re: [PATCH] x86/resctrl: Don't try to free nonexistent RMIDs Message-ID: References: <20240614160843.11006-1-Dave.Martin@arm.com> <1e3bba2e-5cf6-4a77-b92d-5c7ab1661d17@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi, On Mon, Jun 17, 2024 at 08:53:38AM -0700, Reinette Chatre wrote: > Hi Dave, > > On 6/17/24 4:55 AM, Dave Martin wrote: > > Hi Reinette, > > > > On Fri, Jun 14, 2024 at 03:47:58PM -0700, Reinette Chatre wrote: > > > Hi Dave, > > > > > > On 6/14/24 9:08 AM, Dave Martin wrote: > > > > Commit 6791e0ea3071 ("x86/resctrl: Access per-rmid structures by > > > > index") adds logic to map individual monitoring groups into a > > > > global index space used for tracking allocated RMIDs. > > > > > > > > That patch keept the logic to ignore requests to free the default > > > > > > keept -> kept > > > > > > nitpick: I actually do not know if "that patch" gets same hate as > > > "this patch" so to avoid any potential feedback about this I'd like > > > to suggest that this is rewritten without this term. Perhaps > > > something like: "Requests to free the default RMID in free_rmid() > > > are ignored, and this works fine on x86." > > > > > > > RMID in free_rmid(), and this works fine on x86. > > > > > > > > How about recasting the first paragraph into the past tense (since it > > relates a past commit), and rewording as "Requests to free the default > > RMID continued to be ignored in free_rmid(), and this works fine on > > x86." > > Please keep it in the present tense. I do not see this as relating to > a "past commit" but instead it is an existing commit responsible for > current behavior. Documentation/process/maintainer-tip.rst contains > some example changelogs created by x86 maintainers that captures their > requirements. The beginning "context" portion is always in present > tense. Fair enough. I'll reword this as per your suggestion. [...] > > > > Tested on x86 (But so far for the monitors-present case. > > > > > > Tested by booting with "rdt=!cmt,!mbmtotal,!mbmlocal". > > > > Thanks (I take it that's your test, not a request to be more specific > > about mine?) > > Yes, I did test it with those parameters. You are also welcome to > add: > Tested-by: Reinette Chatre Ah, right. Thanks. > > As it happens I tested with rdt=cmt,mbmtotal,mbmlocal,l3cat,l3cdp > > (though I made no effort to exercise these features other than running > > the selftests). I can note this in the commit if you prefer. > > hmmm ... those parameters should not be necessary unless the system > has those features forced off by default because of errata. Doing > functional testing on these systems via such enabling is fine > though. > > Reinette I got these kernel args from James. Apparently some of these features are defaulted to off by the firmware on the box I'm using, but we're not sure why. I haven't dug into it. Cheers ---Dave