From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE3F01AD494 for ; Tue, 18 Jun 2024 10:00:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718704813; cv=none; b=qUF0fenF+iGjmcvneXkcJJYh8/16o/486SbJGaluXh7k85z2n8LnUQVee7Nx5cLxEptch9sDOjZ/hrRzMsuK/2SwOkvrPriC2yzjDDCyqUBG3BLHvtvCp8sB7ng2FP+4KTqCpIBZDNlJl2MsDKJNA2oH0zIO/ghHO/+2pOShCQA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718704813; c=relaxed/simple; bh=aWWT2BtQP7HJiaMGFOBVDWLpLW1OtUGkRwlKM9NdMDI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jRIcyqJGzmb4jyEKLW/TqlHnITGuJT1QlKEzGX3j25uevxyYxmrJJZBQFmVBHcQWXjq2qn10EoddwnCAYQ6ewjdUQOTz2oILsC3ziWx717HSvwksztWk8wycO5xUc75dnPrj9IC8YF0NhwMC78OZ3fyDhvPGohbdRwX/U6E+gOE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=C9Bfkutg; arc=none smtp.client-ip=209.85.208.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="C9Bfkutg" Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2ec0f3b9bb8so35779111fa.1 for ; Tue, 18 Jun 2024 03:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718704809; x=1719309609; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=3EaFvL/kglBgb0ndEbdaou/R+BL7SHB1RSgRjv06fdo=; b=C9BfkutgCXlFd52GOCL6B4LPSUVZB4lZ3/LaJ25PXbduL2oTXEjXrEwej8o2bzZZEc MmQIMA4BdP924cn7Y/3RIBUN+YBE+DhNAjIvjDu7u7Nvr4HM9u4c5Wak0HW1tmbIdtmB mLE6BAJh7au8HwQwg7tnnFOtDwi0fvdsG8+xgO4/em1Y8Vy59nElAquyfy7Vh30Tqlu+ Ka4Zm2+o+G1JZuM7qYVVpAXlNPuf+OFUDs2mt0ukwYB8nzYXvGpgNd8LaiWS4VMAp4/K Kh+bcH5hTlOA2OLvazoQO2PAcqlB8YnamV+seXkrPeigsYwWJfqm3vElnkWd3+pFi8sc c2Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718704809; x=1719309609; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3EaFvL/kglBgb0ndEbdaou/R+BL7SHB1RSgRjv06fdo=; b=p9L4Kesn0q1nuNC4KnULtGR0qo9UzZIQGIX1Fp/1r3Jyi7B1ZOzL3MVDGY28RnygPb FLFovKvHU3T1pEWXw6E9+/6YdtB5iKL6NQaljLH4lRjm5fMVYkdwbcOw3xz7yL9ZXDTm aHocxPxdOC9TpZlTMsnLLaUbYmBclsI0yLOZ5dOkdLFn+SERdUHbWi0QYAETzgHy/T7Q +Qv6l5jHHmv3F1U048+UwWA7Uyh4eCFXmoiJM/P/56AI1aTpJLoYDfKGnv/e/95fpvdN CTIc5ywc7PxezVPFplyLtDiHhBmKfaxvuW/vTOQ9Fo2TGMY0VZopaMGxjq8jqkxylnKf jiwA== X-Forwarded-Encrypted: i=1; AJvYcCW3Ls5mq8ssuB9MTVymRbTHAm2Vm5H8CPw5nClIPzikE58nx/E3of404i+87wsYWBc9FZTU0pKCV596wANesVvyWTnbQXZ/lCpzXWHn X-Gm-Message-State: AOJu0YwKwH69t1cffenMu9RiQBZ1XTwNMjNFh8vm6iToqry3TDkHkv+v e12D3Xbns0HVkMMhEIPOlbU2zcY0RJOjG2uzk3Kv3kL5xA96LMhEybWjQjzWiN4= X-Google-Smtp-Source: AGHT+IEr95PWJXiupXHXyk+N1CJu2nYHBDXKxEW7HsrGyxE8qjcCbSq5QaPzVgVe1c2bfYiW5XdoGQ== X-Received: by 2002:a2e:2e16:0:b0:2eb:d4ea:3c81 with SMTP id 38308e7fff4ca-2ec0e5c6ed6mr85347891fa.22.1718704808767; Tue, 18 Jun 2024 03:00:08 -0700 (PDT) Received: from linaro.org ([82.79.124.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-422f6320c21sm188678265e9.34.2024.06.18.03.00.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jun 2024 03:00:08 -0700 (PDT) Date: Tue, 18 Jun 2024 13:00:06 +0300 From: Abel Vesa To: Johan Hovold Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rajendra Nayak Subject: Re: [PATCH v2] arm64: dts: qcom: x1e80100: Enable tsens and thermal zone nodes Message-ID: References: <20240614-x1e80100-dts-thermal-v2-1-4d4f9effacc6@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 24-06-17 11:24:22, Johan Hovold wrote: > On Fri, Jun 14, 2024 at 01:50:07PM +0300, Abel Vesa wrote: > > From: Rajendra Nayak > > > > Add tsens and thermal zones nodes for x1e80100 SoC. > > > > Signed-off-by: Rajendra Nayak > > Signed-off-by: Abel Vesa > > --- > > Changes in v2: > > - Dropped the thermal engine nodes. > > - Dropped comments from tsens nodes. > > - Droppd the polling-delay entirely and polling-delay-passive where not > > necessary. > > - Added top/bottom location to all sensors (where applicable). > > - Fixed trip points with duplicate values for same temp. > > - Marked as critical the 125°C throughout all trip points. > > - Link to v1: https://lore.kernel.org/r/20240527-x1e80100-dts-thermal-v1-1-ea13b8fa6ffc@linaro.org > > --- > > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1176 ++++++++++++++++++++++++++++++++ > > 1 file changed, 1176 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > > index 9944c654851e..df13df7967db 100644 > > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi > > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > > > + cpu0-0-bottom-thermal { > > + thermal-sensors = <&tsens0 2>; > > + > > + trips { > > + trip-point0 { > > + temperature = <90000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > + > > + trip-point1 { > > + temperature = <95000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > + > > + cpu-critical { > > + temperature = <110000>; > > + hysteresis = <1000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > The CPU bottom thermal zones fail to register with v2: > > [ 0.146219] thermal_sys: Thermal zone name (cpu0-0-bottom-thermal) too long, should be under 20 chars Urgh, did not test after renaming the zones. Talking to Daniel Lezcano, he seems to suggest that the size can become dynamic at some point. For now will switch back to cpu0-0-0-bottom-thermal and cpuss0-0-thermal. So that's O for top and 1 for bottom. TBF, the positions are not really top and bottom on this platform, but rather left top and right bottom. > > Johan