From: Tejun Heo <tj@kernel.org>
To: Christian Loehle <christian.loehle@arm.com>
Cc: rafael@kernel.org, viresh.kumar@linaro.org,
linux-pm@vger.kernel.org, void@manifault.com,
linux-kernel@vger.kernel.org, kernel-team@meta.com,
mingo@redhat.com, peterz@infradead.org,
David Vernet <dvernet@meta.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH 2/2] sched_ext: Add cpuperf support
Date: Wed, 19 Jun 2024 09:19:22 -1000 [thread overview]
Message-ID: <ZnMvOht0usglJOzm@slm.duckdns.org> (raw)
In-Reply-To: <b32a658d-27fd-4f61-8f6f-58fa71af30c8@arm.com>
Hello,
On Wed, Jun 19, 2024 at 03:07:51PM +0100, Christian Loehle wrote:
> > static void sugov_get_util(struct sugov_cpu *sg_cpu, unsigned long boost)
> > {
> > - unsigned long min, max, util = cpu_util_cfs_boost(sg_cpu->cpu);
> > + unsigned long min, max;
> > + unsigned long util = cpu_util_cfs_boost(sg_cpu->cpu) +
> > + scx_cpuperf_target(sg_cpu->cpu);
>
> What does cpu_util_cfs_boost() contain if scx is active?
Hmm... when SCX is in partial mode, cpu_util_cfs_boost() reports the util
metric from cfs side as usual, but, yeah, when scx_switched_all(), this
could be stale. I'll update.
> NIT: reverse xmas
Ah, let me just make the initial assignment a separate statement. Reverse
xmas is awkward with broken lines.
Thanks.
--
tejun
next prev parent reply other threads:[~2024-06-19 19:19 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 3:12 [PATCHSET sched_ext/for-6.11] sched_ext: Integrate with schedutil Tejun Heo
2024-06-19 3:12 ` [PATCH 1/2] cpufreq_schedutil: Refactor sugov_cpu_is_busy() Tejun Heo
2024-06-19 14:07 ` Christian Loehle
2024-06-19 18:57 ` Tejun Heo
2024-06-19 19:07 ` Tejun Heo
2024-06-20 9:40 ` Christian Loehle
2024-06-19 18:45 ` Rafael J. Wysocki
2024-06-19 19:53 ` Tejun Heo
2024-06-20 17:57 ` Rafael J. Wysocki
2024-06-20 18:08 ` Tejun Heo
2024-06-21 22:38 ` Tejun Heo
2024-06-19 3:12 ` [PATCH 2/2] sched_ext: Add cpuperf support Tejun Heo
2024-06-19 14:07 ` Christian Loehle
2024-06-19 19:19 ` Tejun Heo [this message]
2024-06-19 19:51 ` [PATCH v2 " Tejun Heo
2024-06-21 22:39 ` Tejun Heo
2024-07-05 12:41 ` Vincent Guittot
2024-07-05 18:22 ` Tejun Heo
2024-07-06 9:01 ` Vincent Guittot
2024-07-07 1:44 ` Tejun Heo
2024-07-08 6:37 ` Vincent Guittot
2024-07-08 18:20 ` Tejun Heo
2024-07-08 19:51 ` Vincent Guittot
2024-07-08 21:08 ` Tejun Heo
2024-07-09 13:36 ` Vincent Guittot
2024-07-09 16:43 ` Tejun Heo
2024-07-12 10:12 ` Vincent Guittot
2024-07-12 17:10 ` Tejun Heo
2024-07-02 10:23 ` [PATCH " Hongyan Xia
2024-07-02 16:37 ` Tejun Heo
2024-07-02 17:12 ` Hongyan Xia
2024-07-02 17:56 ` Tejun Heo
2024-07-02 20:41 ` Hongyan Xia
2024-07-02 21:12 ` Tejun Heo
2024-07-24 23:45 ` Qais Yousef
2024-07-31 1:05 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnMvOht0usglJOzm@slm.duckdns.org \
--to=tj@kernel.org \
--cc=christian.loehle@arm.com \
--cc=dvernet@meta.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox