public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: nipun.gupta@amd.com, nikhil.agarwal@amd.com
Cc: abhijit.gangurde@amd.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cdx: remove unused struct 'cdx_mcdi_copy_buffer'
Date: Fri, 21 Jun 2024 00:02:41 +0000	[thread overview]
Message-ID: <ZnTDIRpC9xhH4vrO@gallifrey> (raw)
In-Reply-To: <20240530233436.224461-1-linux@treblig.org>

* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'cdx_mcdi_copy_buffer' has been unused since the original
> commit eb96b740192b ("cdx: add MCDI protocol interface for firmware
> interaction").
> 
> Looking at lkml,  it was used in the V1 posting but was removed
> somewhere before V6.
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Ping.

Dave

> ---
>  drivers/cdx/controller/mcdi.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/cdx/controller/mcdi.c b/drivers/cdx/controller/mcdi.c
> index 1eedc5eeb315..e760f8d347cc 100644
> --- a/drivers/cdx/controller/mcdi.c
> +++ b/drivers/cdx/controller/mcdi.c
> @@ -27,10 +27,6 @@
>  #include "bitfield.h"
>  #include "mcdi.h"
>  
> -struct cdx_mcdi_copy_buffer {
> -	struct cdx_dword buffer[DIV_ROUND_UP(MCDI_CTL_SDU_LEN_MAX, 4)];
> -};
> -
>  static void cdx_mcdi_cancel_cmd(struct cdx_mcdi *cdx, struct cdx_mcdi_cmd *cmd);
>  static void cdx_mcdi_wait_for_cleanup(struct cdx_mcdi *cdx);
>  static int cdx_mcdi_rpc_async_internal(struct cdx_mcdi *cdx,
> -- 
> 2.45.1
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

  reply	other threads:[~2024-06-21  0:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-30 23:34 [PATCH] cdx: remove unused struct 'cdx_mcdi_copy_buffer' linux
2024-06-21  0:02 ` Dr. David Alan Gilbert [this message]
2024-06-21  5:17 ` Gupta, Nipun
2024-07-21 22:47   ` Dr. David Alan Gilbert
2024-07-22  4:29     ` Gupta, Nipun
2024-07-22  4:46       ` Greg KH
2024-07-22  5:27         ` Gupta, Nipun
2024-07-22  5:35           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZnTDIRpC9xhH4vrO@gallifrey \
    --to=linux@treblig.org \
    --cc=abhijit.gangurde@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikhil.agarwal@amd.com \
    --cc=nipun.gupta@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox