From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D84C3207 for ; Fri, 21 Jun 2024 03:10:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718939403; cv=none; b=MDuZvXP6pcCUQ70KfmwqNaiLV/DqRiXLLhnQp7scCrs59WDiJxzBTum7mDEYaFOw3F4/Hm6wEgGOktrNNCSiAC1Ve7DaZdEYaj7JWiyU6a6QDpht4xNDepa7Nvu5uzJF294Gx231byFA3+KF4HFCTJsqxOwgem3e05MX8Vkq4To= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718939403; c=relaxed/simple; bh=ADR0M9bzYb/z4xy1FJbEfBdV6vztRWzQN93xqp0dV1g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aIMRwRo9Hm6+mQBvJXkZCuIAdB+h/i9BTZDQVkjw83Dt8DBHAlzUoDUIyEzIXVNE1EKtx+rFqP5eaa3OFDUKpe0n5XJAAfd8fH7M1Whnqs36h/w+tZ7BW1Vwe9ltlW/kMFCCYfw4RhJUgzunPlQ8cSWsOc698zTIAJklp92eWs8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=oP3ghbIx; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="oP3ghbIx" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1f47f07aceaso12301635ad.0 for ; Thu, 20 Jun 2024 20:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1718939400; x=1719544200; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=0v4GHVLko6b2d6yCPPJ+7mz46mQ9AAseTgFJ3I+E9Ss=; b=oP3ghbIxB/l1cOmk3pq4j0X7Zf8FdMjxmNOZoWXjQqrnDf9Y5gVSOAz0jnw60FTJl/ T3QpCUGjAPrmVMYAYyX2wIqhAsZvqLP6Xeg3D5enfvOY2OVlqfA0BV5tOAQWS4qScs+d sWgTk6rkP9a1znXT6pHImXK4QwkpLNIACSZTkddkSHKspV1EgZFnp8a7U5Zc5Si78q7y 47sFPO0GoIJif2e9lAHLk+xXL9yU0VAZB9wiSGFZNr0lagFCTP8/NaIABcAQLm7OZOrf ohAq0MxqkQxJsawkEUpF31Op4ErWpgmXUMRjchrQNkg94IVmjwZp3NDY6TR/bFHYgiVj GmaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718939400; x=1719544200; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0v4GHVLko6b2d6yCPPJ+7mz46mQ9AAseTgFJ3I+E9Ss=; b=bj7bgZ3ZrLd2IokWhO4gk6y5DovBx/S//sKhm728dhPwY0OCkxmMVlwAL7XWyfFbTV V4vGgyKnDhhees+DQ70wSFG9mUhhPl1ODRBdz/FU8J+xII5MtR7dWTnuvR5FmS2l9BPx VmATnq1liFTpwenhUSVDYHu6fPUHo5DvqwpKns/GbxeskvxMKModJjvAR0e/0HMBTFJC aYwe9F9TGU9jeaAi/ZR4lP1Oza/hJD2QfHWbr33p9OqR+NGqfItUpx0MF1m5G1k6tZsy SZ/oErgVgnIdBZAJjJbDi5M/c0rvqbfPGCk89ZH64wKhdxsRaDmHrQqGuvavcKTkG0M2 dCxw== X-Forwarded-Encrypted: i=1; AJvYcCVooQtaCHxMZ3wv4RGXYXB1ehvszPQSnI3K/pmcAi/i6BatVJV+QguUQ9nvr5m5vTY+8IbFi3yFmDgNnWdaTmkAiv8jMHYwQpbI1RTb X-Gm-Message-State: AOJu0Yw0bRrBtDZ2M82QQzgQ5pZebuEw/clM+RzsrPT773EyZW/HIiOe JmSERYLTfM2CJoVxkAGtJB8HIlhrJCC/fVJQr5JTdvADLKUcI2ME30jrYln4DjM= X-Google-Smtp-Source: AGHT+IFFY2CE7Fj0jGtDzkU4sKdGCQMRvDZCbXWHqL9tztfL9yqPx3keG5JRhkAANqhTh3TGHFGhmA== X-Received: by 2002:a17:903:32d1:b0:1f9:c52f:d9b5 with SMTP id d9443c01a7336-1f9c52fdcefmr46099765ad.66.1718939400383; Thu, 20 Jun 2024 20:10:00 -0700 (PDT) Received: from ghost ([2601:647:5700:6860:c36f:e04a:309e:a49]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9eb3c644fsm3537945ad.145.2024.06.20.20.09.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 20:09:59 -0700 (PDT) Date: Thu, 20 Jun 2024 20:09:54 -0700 From: Charlie Jenkins To: yunhui cui Cc: paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alexghiti@rivosinc.com, akpm@linux-foundation.org, bhe@redhat.com, rppt@kernel.org, dawei.li@shingroup.cn, jszhang@kernel.org, namcao@linutronix.de, bjorn@rivosinc.com, vishal.moola@gmail.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [External] Re: [PATCH] RISC-V: cmdline: Add support for 'memmap' parameter Message-ID: References: <20240618120842.15159-1-cuiyunhui@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Jun 21, 2024 at 10:08:39AM +0800, yunhui cui wrote: > Hi Charlie, > > On Fri, Jun 21, 2024 at 9:03 AM Charlie Jenkins wrote: > > > > On Tue, Jun 18, 2024 at 08:08:42PM +0800, Yunhui Cui wrote: > > > Implement support for parsing 'memmap' kernel command line parameter. > > > > > > This patch covers parsing of the following two formats for 'memmap' > > > parameter values: > > > > > > - nn[KMG]@ss[KMG] > > > - nn[KMG]$ss[KMG] > > > > > > ([KMG] = K M or G (kilo, mega, giga)) > > > > > > These two allowed formats for parameter value are already documented > > > in file kernel-parameters.txt in Documentation/admin-guide folder. > > > Some architectures already support them, but Mips did not prior to > > > > Copy-paste from a Mips patch? Should say riscv :) > > > > It looks like this code is duplicated from xtensa and is effectively the > > same as mips. Can this code be placed in a generic file so that the code > > can be shared between mips, riscv, and xtensa -- maybe a new config that > > gets selected by mips/riscv/xtensa? > > Yeah, that's actually what I was thinking. Which general file do you > think would be more suitable to put it in? I am not sure the best place to put it. What do you think about mm/memblock.c next to the "memblock" early param? > > > - Charlie > > > > > this patch. > > > > > > Excerpt from Documentation/admin-guide/kernel-parameters.txt: > > > > > > memmap=nn[KMG]@ss[KMG] > > > [KNL] Force usage of a specific region of memory. > > > Region of memory to be used is from ss to ss+nn. > > > > > > memmap=nn[KMG]$ss[KMG] > > > Mark specific memory as reserved. > > > Region of memory to be reserved is from ss to ss+nn. > > > Example: Exclude memory from 0x18690000-0x1869ffff > > > memmap=64K$0x18690000 > > > or > > > memmap=0x10000$0x18690000 > > > > > > There is no need to update this documentation file with respect to > > > this patch. > > > > > > Signed-off-by: Yunhui Cui > > > --- > > > arch/riscv/mm/init.c | 50 ++++++++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 50 insertions(+) > > > > > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > > > index e3405e4b99af..7be7ec3092ad 100644 > > > --- a/arch/riscv/mm/init.c > > > +++ b/arch/riscv/mm/init.c > > > @@ -208,6 +208,56 @@ static int __init early_mem(char *p) > > > } > > > early_param("mem", early_mem); > > > > > > +static void __init parse_memmap_one(char *p) > > > +{ > > > + char *oldp; > > > + unsigned long start_at, mem_size; > > > + > > > + if (!p) > > > + return; > > > + > > > + oldp = p; > > > + mem_size = memparse(p, &p); > > > + if (p == oldp) > > > + return; > > > + > > > + switch (*p) { > > > + case '@': > > > + start_at = memparse(p + 1, &p); > > > + memblock_add(start_at, mem_size); > > > + break; > > > + > > > + case '$': > > > + start_at = memparse(p + 1, &p); > > > + memblock_reserve(start_at, mem_size); > > > + break; > > > + > > > + case 0: > > > + memblock_reserve(mem_size, -mem_size); > > > + break; > > > + > > > + default: > > > + pr_warn("Unrecognized memmap syntax: %s\n", p); > > > + break; > > > + } > > > +} > > > + > > > +static int __init parse_memmap_opt(char *str) > > > +{ > > > + while (str) { > > > + char *k = strchr(str, ','); > > > + > > > + if (k) > > > + *k++ = 0; > > > + > > > + parse_memmap_one(str); > > > + str = k; > > > + } > > > + > > > + return 0; > > > +} > > > +early_param("memmap", parse_memmap_opt); > > > + > > > static void __init setup_bootmem(void) > > > { > > > phys_addr_t vmlinux_end = __pa_symbol(&_end); > > > -- > > > 2.20.1 > > > > > > > > > _______________________________________________ > > > linux-riscv mailing list > > > linux-riscv@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-riscv > > Thanks, > Yunhui