Re: [PATCH v4 3/4] serial: core: Revert unusable console quirk handling

[Petr Mladek <pmladek@suse.com>]

On Thu 2024-06-20 15:45:28, Tony Lindgren wrote:
> There is no point of trying to handle the console quirks in the serial
> core instead of console_setup() currently.
> 
> With the console_setup() related changes, we are now deferring the
> DEVNAME:0.0 style consoles based on the ":" naming only. So the serial
> core console quirk handling would not do anything for the "ttyS" named
> consoles as they are not deferred.
> 
> Also the earlier approach would have depended on further changes to be
> able to drop the serial port quirk handling from console_setup().
> 
> Let's revert the following console quirk handling related serial core
> commits:
> 
> b20172ca6bf4 ("serial: core: Fix ifdef for serial base console functions")
> 4547cd76f08a ("serial: 8250: Fix add preferred console for serial8250_isa_init_ports()")
> a8b04cfe7dad ("serial: 8250: Add preferred console in serial8250_isa_init_ports()")
> a0f32e2dd998 ("serial: core: Handle serial console options")
> 787a1cabac01 ("serial: core: Add support for DEVNAME:0.0 style naming for kernel console")
> 
> Once the console quirk handling is gone, we add back the DEVNAME:0.0
> functionality with a minimal patch.
> 
> Suggested-by: Petr Mladek <pmladek@suse.com>
> Link: https://lore.kernel.org/linux-serial/ZnGQ8JAu2OQf0GX8@pathway.suse.cz/
> Signed-off-by: Tony Lindgren <tony.lindgren@linux.intel.com>

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr