From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 453E28494 for ; Sat, 22 Jun 2024 00:06:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719014808; cv=none; b=cBoNzb7fS3onHNTmISCh2aem8x0LY5h924+5bNfYH67j5LZm8s0OBctWFfbw3B2pqR0Ib6DNd/PgmybBzEVa6YsHjFSFw2OOwa/rOrPG9t6SRsXGWgjEnaX6PKs5IyDsh1iD+dsLE5kixVEb28ni6lAMw1MOYRlv54ykaHTHTuM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719014808; c=relaxed/simple; bh=2iZCdobCesQIlaIFBjwhULiIkRQI8wcQ8QBqpcXuLO4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=abbe2wv2NGqkk/XI8mn4a2MtAzwThSFwHrfyPF7hRbMye/s9hKUZHhkI/4nIxfdI3rSUmiHa56VHy+kjXEHAkzF5Koo7SmJ1QbR2EIGleKL9vM8U+bl9Aj3bIFl6gomyZOn0HLUF9fcCJ+DVRrrNsoioQuCbWpTpQYsFc4wd9d0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=q4Xqf3sj; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="q4Xqf3sj" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1f70ec6ff8bso231035ad.0 for ; Fri, 21 Jun 2024 17:06:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719014806; x=1719619606; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=50aRBwML1alf49hO+1BmWw804OZfmi02o/xT006me7w=; b=q4Xqf3sjKt+6bs4X7412Tauxe8ZK75EWtXsyRXywJc65KD8yLHzAD7rS696c8rb2ww fyPIiIuPS40v5fDaJC98Dkj//vuZVAtv/DYXUUvHJH9XEexB9TPzCe17YW5hPGd8o/g1 9DsxDex6z78ncsuRV8YQtbbVHaV78oGG0FZM/IlHW9NKX83lkjQ8cOfgh67UmXR561Gk g+ClmliAzy0lnmi8Fq4OwCWfrH4SVw3sFtDoMWwK8Bp8yrboM/pI3i1IWtIxcQK/W89H 3FyuZDlJU83e03n6FFxZEEy6gncSesDECTyiIMc2+PKjFAV+rx1fs5d1vIR/txVIB026 Qisw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719014806; x=1719619606; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=50aRBwML1alf49hO+1BmWw804OZfmi02o/xT006me7w=; b=q8nTwAg0LREam85+d2EXjZYP7XLVQfMUdIL4rcEtx1pr2UWPoWMl66YbN8qT50jaeB jVihMUaXKU8mWDCXla9TXddzQonFLl6arvADOKx9JKQ0LvSQUeftpU7EVRr4ROLqLneN Ru48pIxzk8QsW5TJUeGxQHKVtFe+x9asDZp1hSBX/SVd3w4lp63ApTOqpbLDwr85fgX6 QtriZ5fq0I5QOBdzghOZ+4yNKbke7LXi3JAS2dnPGTIA3FrXfktuXAl9T0B5EDgJ3PRL xkeJXFrEWqrgj7KsOE1R0dv8iEzdCkgQsFb9CLcoFVRBF4usmp6zH47lVcHL4z/QUl4f N2RQ== X-Forwarded-Encrypted: i=1; AJvYcCXuKj3e7PAD91RhF4H117yCsPv1ofk+IjBrUUvbpsE0+dKbOKhiVn+vtuYAHWE+iuzZBq8SrAhH7iN5xrk3HLi4tBQedpH0sx0FbxK+ X-Gm-Message-State: AOJu0YxdQgUdNUB6vqSLV8tbuCtagPmzMeaTa8HYnghqGYyAUdKp88eB cVuoHBRCuwKmRZ8sC4e1XWoeye5MU22Xe8IHcj3qnEn4siSUwQqiL6e56Jo47g== X-Google-Smtp-Source: AGHT+IH2DpcqGgyH+HjMIKHYfMU0Aprz6jSxhq9kEXfnCX/pqvkRFp0LybPg6McZN0Dup2hfAWO3ng== X-Received: by 2002:a17:902:7689:b0:1f9:bc99:d94a with SMTP id d9443c01a7336-1fa09ff2e18mr845625ad.5.1719014806175; Fri, 21 Jun 2024 17:06:46 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-706512d6088sm2058052b3a.175.2024.06.21.17.06.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jun 2024 17:06:45 -0700 (PDT) Date: Fri, 21 Jun 2024 17:06:42 -0700 From: William McVicker To: =?iso-8859-1?Q?Andr=E9?= Draszik Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Griffin , Marek Szyprowski , Sylwester Nawrocki , Alim Akhtar , Sam Protsenko , Krzysztof Kozlowski , Tudor Ambarus , Roy Luo , kernel-team@android.com, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v3 5/6] phy: exynos5-usbdrd: convert Vbus supplies to regulator_bulk Message-ID: References: <20240617-usb-phy-gs101-v3-0-b66de9ae7424@linaro.org> <20240617-usb-phy-gs101-v3-5-b66de9ae7424@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240617-usb-phy-gs101-v3-5-b66de9ae7424@linaro.org> On 06/17/2024, André Draszik wrote: > Using the regulator_bulk APIs, the handling of power supplies becomes > much simpler. There is no need anymore to check if regulators have been > acquired or not, the bulk APIs will do all the work for us. We can also > drop the various handles to the individual power supplies in the driver > runtime data and instead simply treat them all as one thing. Error > cleanup also becomes much simpler. > > Converting to the regulator_bulk APIs also makes it easier to add > support for those SoCs that have additional power supplies for the PHY. > Google Tensor gs101 is one example of such a SoC. Otherwise we'd have > to add all additional supplies individually via individual calls to > regulator_get() and enable/disable handle them all individually, > including complicated error handling. That doesn't scale and clutters > the code. > > Just update the code to use the regulator_bulk APIs. > > Signed-off-by: André Draszik Tested-by: Will McVicker [...] Thanks, Will