Re: [PATCH v3] software node: Implement device_get_match_data fwnode callback

Sui Jingfeng
2024-06-22T18:04:11Z

Hi,

On 6/22/24 03:58, Dmitry Torokhov wrote:
> Hi Sui,
>
> On Sun, Apr 28, 2024 at 04:36:50AM +0800, Sui Jingfeng wrote:
>> Because the software node backend of the fwnode API framework lacks an
>> implementation for the .device_get_match_data function callback. This
>> makes it difficult to use(and/or test) a few drivers that originates
>> from DT world on the non-DT platform.
>>
>> Implement the .device_get_match_data fwnode callback, which helps to keep
>> the three backends of the fwnode API aligned as much as possible. This is
>> also a fundamental step to make a few drivers OF-independent truely
>> possible.
>>
>> Device drivers or platform setup codes are expected to provide a software
>> node string property, named as "compatible". At this moment, the value of
>> this string property is being used to match against the compatible entries
>> in the of_device_id table. It can be extended in the future though.
>
> I am sorry, but this is not really correct.

I fine if the maintainers of fwnode API want to reject this, but got
rejected is not really equals to "not correct".

Software nodes are used to
> augment missing or incomplete parameters, but are never primary objects
> in the matching process. Sometimes "compatible" property is used with
> software nodes, but it does not participate in the matching process. > There are several ways for various buses to match a device and a driver,
> but none of them operate on software nodes.

It's not participate in the matching process in the *past*, but what
we present is something *new*. I fine if you adhere to *old* and/or
*subsystem-dependent* approach, but there really no need to persuade
other people to follow your "old" idea.

Consider for example how
> devices on SPI bus are matched (see
> drivers/spi/spi.c::spi_match_device()):

This only make the driver be able to probed in a non-DT way, but
it doesn't tell how does the *additional device properties* can
be get. This is the key point.

> 1. OF/device tree based match. It *requires* the device to have
> dev->of_node which is coming from a DTB. It does not work on software
> nodes. In case of match the match data should come from of_device_id
> entry.
>
> 2. ACPI-based match. The match is done based either on OF-compatible
> data (which includes "compatible" property) in _DSD (if driver supports
> OF-based matching), or based on HID/CID data. In the latter case the
> match data is coming from acpi_device_id entry.
>
> 3. Name-based match, typically used for board-instantiated devices. In
> this case match is done by comparing device name under which it was
> instantiated against names listed in the drivers id_table. The match
> data is coming from spi_device_id entry.

The statements here sound right, but it's useless. Because the problems
isn't solved yet, nor does you words point out a practical approach.

> Similar matching processes are implemented for i2c and platform buses,
> as well as others.
>
> Your patch is effectively hijacks the #3 matching process and
> substitutes the bus-specific match data (from
> spi_device_id/i2c_device_id/etc) with OF data. This is not expected and

Please stop *contaminating* other people's patch, if you have better
idea you can posting it. My patch open a new door, and there do have
programmer in requesting(need) this in the past.

> while we may want this in a long term (so we can eventually remove these
> bus-specific device ids and only have ACPI/OF ones) I do not think we
> are ready for this yet. At the very least this needs to be very clearly
> documented.

This is your *personal* wants, if you want to remove something,
just do it. Keep quiet if you are not ready. Exposing your concerns
doesn't help to solve any problems.

Or, if you want it to be clear, you can contribute to Documentation/
gpu/todo.rst. Other peoples help you to become clear there, thanks.

Please note that we are talking about the completeness of the fwnode
APIs, what's you say above has nothing to do the device fwnode APIs.
Hence, is not revelant to my patch, again is out of scope.

>>
>> Fixes: ffb42e64561e ("drm/tiny/repaper: Make driver OF-independent")
>> Fixes: 5703d6ae9573 ("drm/tiny/st7735r: Make driver OF-independent")
>
> As other people mentioned this patch does not fix the aforementioned
> commits because they are not broken.

You still not really understand what other people does, I'm not saying
it broken. I'm talking about the completeness.

In case of non-OF match (which
> includes the case where you use software nodes) the match data is coming
> from matching spi_device_id entry in the driver.

We don't care about much how it is probed now, rather, after the driver
probed by a non-OF way, how does the additional devices properties
can be get?

Say:

1) "device_property_read_u32(dev, "rotation", &rotation);" and
2) "!device_property_read_string(dev, "pervasive,thermal-zone",
&thermal_zone))"

For those spi/i2c/platform devices, what we argues are that
those drivers really should just depend on "OF" before we have
a reliable fwnode API backend to redirect to.

Where the additional device_property_read_xxxx() calls redirect to?

What if users want to invoke more device_property_read_xxxx() function?