From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97D7B4776A; Mon, 24 Jun 2024 12:18:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719231529; cv=none; b=CmrMMnBEWikr/IrUtSRBiIzkdv45x5RZiRpr5m6x19v1+h6oWNEswd78qnQKBfq91h3oNuyJA6py8MQo98WiV7LoeO6x5yTkSBoHT3ACjZ6+I/HJ8EWObavKU4fxSLTkzVOXhEucxExRWiVN7A1mdlfbhcQ0qT7edhVWD+1vDgE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719231529; c=relaxed/simple; bh=Q2jwPxeSpOSVN20g5wzq07/iFIp8leiAtqDeGO2zsWg=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Qcqpheh0LRPvc0u6GBwZ2e5HpQ2nzZtMlKILn36GGQviciYEVdP0OAZtGyXt2mJISbSIiPrrj9xjiJ1Pns8vMO3RPcHttC2UkvvQKYq35/VYR687ACYs+x8kjCJ3cE9rySIIBO/Yqvp23B7r8ti4biAZNcr9+OC1P1yCAR3xkss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HTmr34s0; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HTmr34s0" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-52cd717ec07so3219377e87.0; Mon, 24 Jun 2024 05:18:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719231526; x=1719836326; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=pI+IBO8mbNLx4EB6hYvwY+pSQvTtQIyHsgLM0FFnMHc=; b=HTmr34s0xs8VPQ4h0IxP8GxNdiUUZ4BgddehBGt9s6BRACNV/568yBHatwIl5JUQFw PXZE4MIIqEte9myz/v2D/jNuXM7EH5hab2MbIeSAT/uHIUw2K7YzFxxVnY+udSJLE8ke NqSWwa/uRWSfjaNlbM2FXOCiw2jI4KVJ08+fmkAT2tlEtLNM110mQK2tAei3y+GF3yqM cIJyaWgGV2i3fFYNqL+U3haTIzE5YMFhW+rdKMdro+SCqmjyKXx0tiuqCsSV+Zj/ucLl P68FJEPT1vzogxBK7KCDUxjrCY4hTuBAv8lBb03Jl2BDIA3dum58I9j3VD7ym2BhkgvL ixvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719231526; x=1719836326; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pI+IBO8mbNLx4EB6hYvwY+pSQvTtQIyHsgLM0FFnMHc=; b=ktxCBGSa9r1GoAnyp43JQg8xN1Ptye+4BEOkSW9tJFBDMOwy31VXSO6dhMU71HHrVJ WfONmDoMKAvUY55waj1yYQRRlie5iwN4GTonyZx8kPQ4iuAp9OaFCi6XHa1PfWMW2hU5 hhNsv1UEYew9wSdpJIM/4b+jpvQXMpKI/IndkORFavlenhw8jlU80pDeUvGVyDzzwJhq OBaZQHHKmnHWYNFyAgZtPrtfgrQ5nNSCjSG8YQZKfipJ3URTobZX4nwt7NZJZ80xf4o4 7MuChhMwEnwTuUXHolJHyZEZHdiCFVIGk6BnUXwQWmonElGPnOW3PVUt7hEQUzPoLlhD 9X5A== X-Forwarded-Encrypted: i=1; AJvYcCVUTjGHgYA+g9hDQcqh7/ufGCwVNDF1tBiZ+aUDAdkGNH6nm235E6QQT/+0Ygo7qPZ3Zi8jk0XSPsr8zltqSfn9qja+D4PU+OpRXwqsr7e8eoXdfIgf0nEvwCp+us4P4rYpvDORVA3SEw== X-Gm-Message-State: AOJu0YzoihFe0a+uzsldC7gK63r1NY7uCUXXV4dTIO2lWYyas1ueusWe 0gjyHwhqdZr3yMVfwoG+KDIUBgx/04rfrXBEavJhNrszgYk4CH3OJkgv2Q== X-Google-Smtp-Source: AGHT+IGOhdNKCJLKfAuk/c+639B/KspuwzTM0seZDswX1n8I2/wI73HfO1Ej7KKMpMuoOrjlYz8GWA== X-Received: by 2002:a05:6512:3450:b0:52c:dea8:7ca0 with SMTP id 2adb3069b0e04-52ce185cf71mr2383149e87.55.1719231525645; Mon, 24 Jun 2024 05:18:45 -0700 (PDT) Received: from pc636 (host-90-233-219-252.mobileonline.telia.com. [90.233.219.252]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52cd64390d6sm981488e87.238.2024.06.24.05.18.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 05:18:45 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 24 Jun 2024 14:18:43 +0200 To: Hailong Liu Cc: Uladzislau Rezki , Baoquan He , Nick Bowler , linux-kernel@vger.kernel.org, Linux regressions mailing list , linux-mm@kvack.org, sparclinux@vger.kernel.org, Andrew Morton Subject: Re: PROBLEM: kernel crashes when running xfsdump since ~6.4 Message-ID: References: <75e17b57-1178-4288-b792-4ae68b19915e@draconx.ca> <00d74f24-c49c-460e-871c-d5af64701306@draconx.ca> <20240621033005.6mccm7waduelb4m5@oppo.com> <20240621111545.awvgrap2nscgehxv@oppo.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240621111545.awvgrap2nscgehxv@oppo.com> > > IMO, I thought we can fix this by following. > It doesn't initialize unused variables and utilize the percpu xarray. If I said > anything wrong, please do let me know. I can learn a lot from you all :). > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 11fe5ea208aa..f9f981674b2d 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -4480,17 +4480,21 @@ void __init vmalloc_init(void) > */ > vmap_area_cachep = KMEM_CACHE(vmap_area, SLAB_PANIC); > > - for_each_possible_cpu(i) { > + for (i = 0; i < nr_cpu_ids; i++) { > struct vmap_block_queue *vbq; > struct vfree_deferred *p; > > vbq = &per_cpu(vmap_block_queue, i); > + xa_init(&vbq->vmap_blocks); > + > + if (!cpu_possible(i)) Why do you need such check? Thanks! -- Uladzislau Rezki