From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Shiji Yang <yangshiji66@outlook.com>
Cc: linux-mips@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Javier Martinez Canillas <javierm@redhat.com>,
Khalid Aziz <khalid@gonehiking.org>, Baoquan He <bhe@redhat.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Serge Semin <fancer.lancer@gmail.com>,
linux-kernel@vger.kernel.org,
Mieczyslaw Nalewaj <namiltd@yahoo.com>
Subject: Re: [PATCH V2] mips: kernel: fix detect_memory_region() function
Date: Tue, 25 Jun 2024 09:46:34 +0200 [thread overview]
Message-ID: <Znp12j23mf1bUEqp@alpha.franken.de> (raw)
In-Reply-To: <TYCP286MB089598ABD1E2F66003D71EB8BCD52@TYCP286MB0895.JPNP286.PROD.OUTLOOK.COM>
On Tue, Jun 25, 2024 at 09:44:44AM +0800, Shiji Yang wrote:
> for (size = sz_min; size < sz_max; size <<= 1) {
> - if (!memcmp(dm, dm + size, sizeof(detect_magic)))
> - break;
> + __raw_writel(MIPS_MEM_TEST_PATTERN, dm);
> + if (__raw_readl(dm) == __raw_readl(dm + size)) {
> + __raw_writel(~MIPS_MEM_TEST_PATTERN, dm);
> + if (__raw_readl(dm) == __raw_readl(dm + size))
> + break;
> + }
you are testing memory, so just use pointers. __raw_readl and __raw_writel
are for io regions (which should be ioremppaed before usage).
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2024-06-25 7:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 1:44 [PATCH V2] mips: kernel: fix detect_memory_region() function Shiji Yang
2024-06-25 1:58 ` Jiaxun Yang
2024-06-29 4:56 ` Shiji Yang
2024-06-25 7:46 ` Thomas Bogendoerfer [this message]
2024-06-25 7:52 ` Thomas Bogendoerfer
2024-06-29 5:19 ` Shiji Yang
2024-06-28 16:07 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Znp12j23mf1bUEqp@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=javierm@redhat.com \
--cc=jiaxun.yang@flygoat.com \
--cc=khalid@gonehiking.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=namiltd@yahoo.com \
--cc=yangshiji66@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox