Re: [PATCH 2/3] ARM: Fix crash kenrel data type bug

Linus Walleij
2024-08-05T07:14:53Z

On Mon, Jul 8, 2024 at 3:29 PM Jinjie Ruan <ruanjinjie@huawei.com> wrote:

> On QEMU vexpress-a9 with 1GB memory, the crash kernel "crashkernel=4G"
> is ok as below:
> Reserving 4096MB of memory at 2432MB for crashkernel (System RAM: 1024MB)
>
> The above info is confusing, because the System memory is as below:
> # cat /proc/iomem | grep Sys
> 60000000-9fffffff : System RAM
>
> The cause is that the crash_size is parsed and printed with "unsigned long
> long" data type which is 8 bytes but used with "phys_addr_t" which is
> 4 bytes in memblock_phys_alloc_range().

Is that the whole explanation?

> /* invalid value specified or crashkernel=0 */
> + crash_size = (phys_addr_t)crash_size;
> if (ret || !crash_size)
> return;

How did crash_size get assigned before you added this oneliner?

Yours,
Linus Walleij