From: Charlie Jenkins <charlie@rivosinc.com>
To: Conor Dooley <conor@kernel.org>
Cc: Xiao Wang <xiao.w.wang@intel.com>,
Alexandre Ghiti <alexghiti@rivosinc.com>,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, atishp@atishpatra.org,
anup@brainfault.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/perf: riscv: Remove redundant macro check
Date: Tue, 9 Jul 2024 13:29:42 -0700 [thread overview]
Message-ID: <Zo2dtuv0quQ7FwtK@ghost> (raw)
In-Reply-To: <20240708-wildcard-denim-12de7fae795b@spud>
On Mon, Jul 08, 2024 at 01:22:11PM +0100, Conor Dooley wrote:
> On Mon, Jul 08, 2024 at 08:12:24PM +0800, Xiao Wang wrote:
> > The macro CONFIG_RISCV_PMU must have been defined when riscv_pmu.c gets
> > compiled, so this patch removes the redundant check.
>
> Did you investigate why this define was added? Why do you think that it
> is redundant, rather than checking the incorrect config option?
This file is only compiled with CONFIG_RISCV_PMU:
# drivers/perf/Makefile
obj-$(CONFIG_RISCV_PMU) += riscv_pmu.o
So having this check does seem redundant. I am copying Alex as it looks
like he wrote this.
- Charlie
>
> Cheers,
> Conor.
>
> >
> > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> > ---
> > drivers/perf/riscv_pmu.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/perf/riscv_pmu.c b/drivers/perf/riscv_pmu.c
> > index 0a02e85a8951..7644147d50b4 100644
> > --- a/drivers/perf/riscv_pmu.c
> > +++ b/drivers/perf/riscv_pmu.c
> > @@ -39,7 +39,6 @@ void arch_perf_update_userpage(struct perf_event *event,
> > userpg->cap_user_time_short = 0;
> > userpg->cap_user_rdpmc = riscv_perf_user_access(event);
> >
> > -#ifdef CONFIG_RISCV_PMU
> > /*
> > * The counters are 64-bit but the priv spec doesn't mandate all the
> > * bits to be implemented: that's why, counter width can vary based on
> > @@ -47,7 +46,6 @@ void arch_perf_update_userpage(struct perf_event *event,
> > */
> > if (userpg->cap_user_rdpmc)
> > userpg->pmc_width = to_riscv_pmu(event->pmu)->ctr_get_width(event->hw.idx) + 1;
> > -#endif
> >
> > do {
> > rd = sched_clock_read_begin(&seq);
> > --
> > 2.25.1
> >
> >
> > _______________________________________________
> > linux-riscv mailing list
> > linux-riscv@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-07-09 20:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 12:12 [PATCH] drivers/perf: riscv: Remove redundant macro check Xiao Wang
2024-07-08 12:22 ` Conor Dooley
2024-07-09 20:29 ` Charlie Jenkins [this message]
2024-07-09 20:44 ` Conor Dooley
2024-07-09 20:57 ` Charlie Jenkins
2024-07-09 21:04 ` Conor Dooley
2024-07-09 21:43 ` Atish Patra
2024-07-10 6:03 ` Wang, Xiao W
2024-09-17 13:00 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zo2dtuv0quQ7FwtK@ghost \
--to=charlie@rivosinc.com \
--cc=alexghiti@rivosinc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@atishpatra.org \
--cc=conor@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox