From: Ming Lei <ming.lei@redhat.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: Jens Axboe <axboe@kernel.dk>, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>,
Thomas Gleixner <tglx@linutronix.de>,
Christoph Hellwig <hch@lst.de>,
Frederic Weisbecker <fweisbecker@suse.com>,
Mel Gorman <mgorman@suse.de>, Hannes Reinecke <hare@suse.de>,
Sridhar Balaraman <sbalaraman@parallelwireless.com>,
"brookxu.cn" <brookxu.cn@gmail.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2 3/3] lib/group_cpus.c: honor housekeeping config when grouping CPUs
Date: Sun, 30 Jun 2024 21:39:59 +0800 [thread overview]
Message-ID: <ZoFgLxGXrk4VCR03@fedora> (raw)
In-Reply-To: <20240627-isolcpus-io-queues-v2-3-26a32e3c4f75@suse.de>
On Thu, Jun 27, 2024 at 04:10:53PM +0200, Daniel Wagner wrote:
> group_cpus_evenly distributes all present CPUs into groups. This ignores
The above isn't true, it is really cpu_possible_mask which is
distributed, instead of all present CPUs.
> the isolcpus configuration and assigns isolated CPUs into the groups.
>
> Make group_cpus_evenly aware of isolcpus configuration and use the
> housekeeping CPU mask as base for distributing the available CPUs into
> groups.
>
> Fixes: 11ea68f553e2 ("genirq, sched/isolation: Isolate from handling managed interrupts")
isolated CPUs are actually handled when figuring out irq effective mask,
so not sure how commit 11ea68f553e2 is wrong, and what is fixed in this
patch from user viewpoint?
Thanks,
Ming
next prev parent reply other threads:[~2024-06-30 13:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 14:10 [PATCH v2 0/3] nvme-pci: honor isolcpus configuration Daniel Wagner
2024-06-27 14:10 ` [PATCH v2 1/3] blk-mq: add blk_mq_num_possible_queues helper Daniel Wagner
2024-06-28 6:02 ` Christoph Hellwig
2024-06-28 6:23 ` Hannes Reinecke
2024-06-30 8:24 ` Sagi Grimberg
2024-06-27 14:10 ` [PATCH v2 2/3] nvme-pci: limit queue count to housekeeping CPUs Daniel Wagner
2024-06-28 6:03 ` Christoph Hellwig
2024-06-28 6:24 ` Hannes Reinecke
2024-06-30 8:25 ` Sagi Grimberg
2024-06-27 14:10 ` [PATCH v2 3/3] lib/group_cpus.c: honor housekeeping config when grouping CPUs Daniel Wagner
2024-06-28 6:03 ` Christoph Hellwig
2024-06-28 6:24 ` Hannes Reinecke
2024-06-30 8:25 ` Sagi Grimberg
2024-06-30 13:39 ` Ming Lei [this message]
2024-07-01 7:08 ` Daniel Wagner
2024-07-01 7:21 ` Ming Lei
2024-07-01 8:19 ` Daniel Wagner
2024-07-01 8:47 ` Ming Lei
2024-07-01 8:43 ` Hannes Reinecke
2024-07-01 9:16 ` Ming Lei
2024-07-01 2:09 ` Ming Lei
2024-07-01 6:43 ` Hannes Reinecke
2024-07-01 7:10 ` Ming Lei
2024-07-01 8:37 ` Hannes Reinecke
2024-07-02 7:25 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoFgLxGXrk4VCR03@fedora \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=brookxu.cn@gmail.com \
--cc=dwagner@suse.de \
--cc=fweisbecker@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mgorman@suse.de \
--cc=sagi@grimberg.me \
--cc=sbalaraman@parallelwireless.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox