Re: [PATCH v2] efi: libstub: add support for the apple_set_os protocol

Aditya Garg
2024-07-01T10:40:18Z

> On 1 Jul 2024, at 1:21 PM, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Mon, 1 Jul 2024 at 09:44, Lukas Wunner <lukas@wunner.de> wrote:
>>
>> On Mon, Jul 01, 2024 at 09:30:34AM +0200, Ard Biesheuvel wrote:
>>> Assuming that Intel Macs implement the EFI SMBIOS protocol, reusing
>>> the existing pieces should be rather straight-forward. Something like
>>> the below should work in that case (whitespace damage courtesy of
>>> gmail)
>>>
>>> Note that the smbios.c libstub source file needs some changes to
>>> build correctly for x86 with CONFIG_EFI_MIXED=y, but I can take care
>>> of that.
>>
>> Orlando, Aditya, could you test Ard's patch with CONFIG_EFI_MIXED=n?
>>
>
> Yes, please test so we can check whether Intel Macs expose this
> protocol in the first place.
>
> Note that the following hunk is needed too:
>

The patch works Ard

Tested-by: Aditya Garg <gargaditya08@live.com>

For reference, here is kernel configuration of the kernel used to test this: https://pastebin.com/GPaxRWC6
> diff --git a/drivers/firmware/efi/libstub/Makefile
> b/drivers/firmware/efi/libstub/Makefile
> index 06f0428a723c..1f32d6cf98d6 100644
> --- a/drivers/firmware/efi/libstub/Makefile
> +++ b/drivers/firmware/efi/libstub/Makefile
> @@ -77,5 +77,5 @@
> lib-$(CONFIG_ARM) += arm32-stub.o
> lib-$(CONFIG_ARM64) += kaslr.o arm64.o arm64-stub.o smbios.o
> -lib-$(CONFIG_X86) += x86-stub.o
> +lib-$(CONFIG_X86) += x86-stub.o smbios.o
> lib-$(CONFIG_X86_64) += x86-5lvl.o
> lib-$(CONFIG_RISCV) += kaslr.o riscv.o riscv-stub.o