Re: [PATCH v2] efi: libstub: add support for the apple_set_os protocol

Ard Biesheuvel
2024-07-01T05:11:34Z

On Mon, 1 Jul 2024 at 06:46, Orlando Chamberlain
<orlandoch.dev@gmail.com> wrote:
>
>
> On Mon, 1 Jul 2024 at 05:24, Aditya Garg <gargaditya08@live.com> wrote:
> >
> > From: Aditya Garg <gargaditya08@live.com>
> >
> > 0c18184de990 ("platform/x86: apple-gmux: support MMIO gmux on T2 Macs")
> > brought support for T2 Macs in apple-gmux. But in order to use dual GPU,
> > the integrated GPU has to be enabled. On such dual GPU EFI Macs, the EFI
> > stub needs to report that it is booting macOS in order to prevent the
> > firmware from disabling the iGPU.
> >
> > This patch is also applicable for some non T2 Intel Macs.
> >
> > Based on this patch for GRUB by Andreas Heider <andreas@heider.io>:
> > https://lists.gnu.org/archive/html/grub-devel/2013-12/msg00442.html
> >
> > Credits also goto Kerem Karabay <kekrby@gmail.com> for helping porting
> > the patch to the Linux kernel.
> >
> > Signed-off-by: Aditya Garg <gargaditya08@live.com>

> I've checked that this patch works for me when applied to 6.10-rc6.
> I can also use https://github.com/0xbb/gpu-switch to make the boot gpu
> the iGPU now.
>
> Tested-By: Orlando Chamberlain <orlandoch.dev@gmail.com> (MacBookPro16,1)
>

Thanks.

Is there any point to making this set_os() call if CONFIG_APPLE_GMUX
is not enabled?