public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4 0/2] adp5588-keys: Support for dedicated gpio operation
@ 2024-07-01 15:04 Utsav Agarwal via B4 Relay
  2024-07-01 15:04 ` [PATCH v4 1/2] Input: adp5588-keys - add support for pure gpio Utsav Agarwal via B4 Relay
  2024-07-01 15:04 ` [PATCH v4 2/2] dt-bindings: input: Update dtbinding for adp5588 Utsav Agarwal via B4 Relay
  0 siblings, 2 replies; 11+ messages in thread
From: Utsav Agarwal via B4 Relay @ 2024-07-01 15:04 UTC (permalink / raw)
  To: Utsav Agarwal, Michael Hennerich, Dmitry Torokhov, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Nuno Sá
  Cc: linux-input, devicetree, linux-kernel, Arturs Artamonovs,
	Vasileios Bimpikas, Oliver Gaskell

Current state of the driver for the ADP5588/87 only allows partial
I/O to be used as GPIO. This support was previously present as a
separate gpio driver, which was dropped with the commit
5ddc896088b0 ("gpio: gpio-adp5588: drop the driver") since the
functionality was deemed to have been merged with adp5588-keys.

This series of patches re-enables this support by introducing a new
property names "gpio-only", which allows the driver to relax the
requirement for registering a keymap and enable pure GPIO operation. 

Changelog
==========

V2: 
	-  Changed gpio_only from a local variable to a member of struct
	adp5588_kpad
	-  Removed condition from adp5588_probe() to skip adp5588_fw_parse() if 
	gpio-only specified. adp558_fw_parse() now handles and returns
	0 if gpio-only has been specified.
	-  Added a check in adp5588_fw_parse() to make sure keypad 
	properties(keypad,num-columns and keypad,num-rows) were not defined when 
	gpio-only specified

V3:
	-  Moved device_property_present() for reading "gpio-only" into 
	adp558_fw_parse()
	-  Added print statements in case of error

V4:
	- Added dt-bindings patch

Signed-off-by: Utsav Agarwal <utsav.agarwal@analog.com>
---
Utsav Agarwal (2):
      Input: adp5588-keys - add support for pure gpio
      dt-bindings: input: Update dtbinding for adp5588

 .../devicetree/bindings/input/adi,adp5588.yaml     | 28 ++++++++++++++++---
 drivers/input/keyboard/adp5588-keys.c              | 32 ++++++++++++++++++++++
 2 files changed, 56 insertions(+), 4 deletions(-)
---
base-commit: 1c52cf5e79d30ac996f34b64284f2c317004d641
change-id: 20240701-adp5588_gpio_support-65db2bd21a9f

Best regards,
-- 
Utsav Agarwal <utsav.agarwal@analog.com>



^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2024-07-03  8:41 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-01 15:04 [PATCH v4 0/2] adp5588-keys: Support for dedicated gpio operation Utsav Agarwal via B4 Relay
2024-07-01 15:04 ` [PATCH v4 1/2] Input: adp5588-keys - add support for pure gpio Utsav Agarwal via B4 Relay
2024-07-01 15:04 ` [PATCH v4 2/2] dt-bindings: input: Update dtbinding for adp5588 Utsav Agarwal via B4 Relay
2024-07-01 15:46   ` Conor Dooley
2024-07-01 17:46     ` Dmitry Torokhov
2024-07-02 10:20       ` Agarwal, Utsav
2024-07-02 15:42       ` Conor Dooley
2024-07-03  8:44         ` Nuno Sá
2024-07-01 16:27   ` Rob Herring (Arm)
2024-07-02  9:57     ` Agarwal, Utsav
2024-07-01 20:14   ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox