From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C189B85626; Mon, 1 Jul 2024 23:21:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719876114; cv=none; b=UYHKjNP8XEzYfneRrCSLPGuu3Q4raxunCWStEWPEDZjTyYzQJ1va+GvaW/5cZQITsdXG09drbt0fY0807NicPn/kQq5MZgzbL9MToqfoJEEFH1Y0wtm15p2L2vrL5wuS35HXUMlcQLC2/QZoxCtdIsGwrGv4IGHq++HpfXsfaSs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719876114; c=relaxed/simple; bh=l161noe5d4m1fHPVwe7LFmqgbONJXsfZmxoUYVpLqK0=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=g8lIN9LMxa1mpZWuYY2uF9qREA8ePYa8CpMTUzBUP9r0H+2QVJ5JllWzNJmzlb+2ZZ3nJiXosXPX9whCSTGVQGYTnASEzWj+ThzeUl/Dpu6uzKuqiLE3OsHCPhZO9QtQFGfheihGpKrPI/vHRIsTY8lu8AkgSoraxMMuYIre/0c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gsnw295q; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gsnw295q" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-425624255f3so21349135e9.0; Mon, 01 Jul 2024 16:21:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719876111; x=1720480911; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=J4N/GP5VmiaJVWsKvPXL+RPq8dWI4QSa+5yYoGERr4Q=; b=Gsnw295q5scrrXu0TFKtbQ8hgCP9IIrPCLoXk2kwuqWJkOjM0Y1+X2RAeHTQqjjTn4 hU2vMWsMiVZNpUP3YUlj6RfeMQL8imzWVRRsF878Bh8l2pKoD6DeOa6Ce4tjDROD+/rW ARd3E4FWPpDo6/PRDdaCPghj6yCa85j7EDqKcvHHxAT5csYUQarhz/eDrj+S86CJn2TB EOFV0DYu1sut5KXx4ndJkv/nZYfCtu2EnwT9JTjQfpoDWeEyWYqaJM/wkj0BAahPbaUC G+rOiO9gP2hJAmovPeT3R6hp3qmLSJtxfqPIz+yS22hCJ3wkvPeRo6s9KeB8HFEm8sSE PRZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719876111; x=1720480911; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=J4N/GP5VmiaJVWsKvPXL+RPq8dWI4QSa+5yYoGERr4Q=; b=Gh9c42HWu/uQlThMRtZy7ZU5pFFHs+yIaFkqDzJzle13jKKGGi0cWDAJdNxnhRfvDW HDQi0QxBfo9OU19gvNAJbJ74uDwka8S7lBs60/AvRDNEnMMqiVMH3OkNrLPCuGYPHgk5 Jpiy5NKxxZW8r024ut4VdyXnV/Ft38WKJ/PqP5CMGU31F4p49voQ+x2Y4sfesAgzQLIf AViwBNko3HrI9FO9h4qFOnmUIFTvs4u0VeobUF9YqlhhUeRMV6o+lxzX6rNlgyCGUmuL egIovBLjMhsdjIQ3PMrKKONvfGZV55eVyDlYm1mKr6EHOsIo5/zCGRA/UqJsxsDZHDWs 3fQw== X-Forwarded-Encrypted: i=1; AJvYcCUP797ABUoF4axI4J12rVqIcKztOa757Yz9uti9g8+GgxuKsXLNYKPoPoplWaAOGCr+kZDIOzQcVzEncV226tYOmkqx X-Gm-Message-State: AOJu0YyspSmAmDx1hEQo/yM0KQu6VpbWp7RAJsE3gYBnyxjntoN+e4yJ LFUs7NXonzwwfeECWsqNpev+orAXwj4TEUS/jTSef0ojB9KvKOwp X-Google-Smtp-Source: AGHT+IFiJrVlOS6nSZr2vq22HUDj+b44fPA0H26+dRRG9DhHLPNlLhirN66WtpD66w7oFRyz+tXl3Q== X-Received: by 2002:a05:600c:1d20:b0:424:a823:51d8 with SMTP id 5b1f17b1804b1-4256d4fb273mr88007515e9.11.1719876111076; Mon, 01 Jul 2024 16:21:51 -0700 (PDT) Received: from krava ([176.105.156.1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3675a0cd707sm11374193f8f.1.2024.07.01.16.21.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 16:21:50 -0700 (PDT) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Tue, 2 Jul 2024 01:21:45 +0200 To: Christian Kujau , Daniel Borkmann Cc: linux-kernel@vger.kernel.org, Martin KaFai Lau , bpf@vger.kernel.org, Alexei Starovoitov , Andrii Nakryiko , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , regressions@lists.linux.dev, patchwork-bot+netdevbpf@kernel.org, peter.ujfalusi@intel.com Subject: Re: [regression] =?utf-8?Q?bpf=5Flocal=5Fs?= =?utf-8?B?dG9yYWdlLmM6Nzg1OjYwOiBlcnJvcjog4oCYa3ZtYWxsb2NfYXJyYXlfbm9k?= =?utf-8?B?ZV9ub3Byb2bigJkgc2l6ZXMgc3BlY2lmaWVkIHdpdGgg4oCYc2l6ZW9m4oCZ?= Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jul 01, 2024 at 10:56:22PM +0200, Christian Kujau wrote: > This has been brought up before along with a patch[0] but has not been > pushed to mainline: > > $ make allnoconfig > $ enable CONFIG_WERROR and CONFIG_BPF > $ make > [...] > kernel/bpf/bpf_local_storage.c: In function ‘bpf_local_storage_map_alloc’: > kernel/bpf/bpf_local_storage.c:785:60: error: ‘kvmalloc_array_node_noprof’ sizes specified with ‘sizeof’ in the earlier > argument and not in the later argument [-Werror=calloc-transposed-args] > 785 | smap->buckets = bpf_map_kvcalloc(&smap->map, sizeof(*smap->buckets), > | ^ > > I always compile kernels with CONFIG_WERROR=y and I'm surprised that this > has not been caught by any build bots yet (or I did not see those > reports), the help text even says "If in doubt, say Y", so I'm very > puzzled why almost nobody else would be affected by this. The compilation > error happens on a Fedora 40 laptop, with gcc 14.1.1 20240620 (Red Hat > 14.1.1-6) installed. > > The fix posted in [0] does fix the compilation errors, but maybe never > made it to the correct trees to be included upstream? We are already in > -rc6 and I fear that the next release will be shipped with that problem. > > Thanks, > Christian. > > [0] https://lore.kernel.org/bpf/363ad8d1-a2d2-4fca-b66a-3d838eb5def9@intel.com/T/ hum.. it's in bpf-next and linux-next tree [1], but not sure it's on the way for next release.. Daniel? jirka [1] 6f130e4d4a5f bpf: Fix order of args in call to bpf_map_kvcalloc > -- > BOFH excuse #424: > > operation failed because: there is no message for this error (#1014)