From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 768913BBF6 for ; Tue, 2 Jul 2024 05:46:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719899176; cv=none; b=dBLJAwtDY8k9mcZKzq+qbMqy9UMWODTUFAxKKxi9ItkP9q4CvN0Uw1Wu0UcsJatrb2fqlQy8nCxN/eIp1lJf3qSuCGnCpS9/q38X6h6ipWO9Tm5GUsJlEQq5QSk44m2cBy/fr/jSigX7tgAXdAUwiTbqmILzvq7+5YuuFpyuKcc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719899176; c=relaxed/simple; bh=AdkaUjRTJIhO/K8YUDZQ1Q0hdKG/eUYO18zWbxAkJ+k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r/nrtbuKW/23aSUsaI8JHOuIl17EMNgZEXJU/5v2vKHgOtyTcUzO6zG46GxPviTCcdyvxGq/IzWeV7SqaTd/vgbBMDrXB0WI2981SC4dwOanPkTC5/GQyfG4k0AV3FGZzn47vV8mNr1cfjHjZjXIL3GUTFN6Xn+pBCI5o+o/NeI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=xU+Qz5vt; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="xU+Qz5vt" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-70679845d69so2412469b3a.1 for ; Mon, 01 Jul 2024 22:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1719899173; x=1720503973; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BGGBEWgqwliEqnZATHjMM1K2Xkz4OG63sXpZDZIsbfo=; b=xU+Qz5vtMWlGv7Gpl1n5kg3KOGQIqSgzjPs7s2nu71MB+EpE9biNDMVboQiGHCcpyf 7cR47w3w2+9SjvSB/MBcX1JC62f0LrS/vHHcaqlNUF1ZoVOZSolmCMcQlFu/rmzj2giO PwXFtHM6BITw4FDAy7Z8UQ1jzlhmsM8FwsTKFhFvnppjICROWWSHjAVp7/McPhAJ22sT uBWqUH4WVrs+UlavQrViqht1TjsWuQd74/OOmtd4zpxem9KlGDCm18GUH/On6PYF8KbH 0dfZZwv6GCgVwmhy/mcAL5snTQdjZZTYfHzN8iz7AkTOuCKO0s8q/8YQlkXAvFV8fAn/ OWfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719899173; x=1720503973; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BGGBEWgqwliEqnZATHjMM1K2Xkz4OG63sXpZDZIsbfo=; b=giMjrQZSfWDS6noQaSyRaifYiYxMYQd1trTNpdpNgZNqq143dk2CksD5c4F4fVHKLl EhPKNhMPur5dkQx8mNEEfDDuc1ONw2Q9xrRYGU1IolwmcKnVDP/PqS0hS1Dt55/TSlYN IK+uixPml5v4/F1zLYyTNFKxMtEnVCPWdpOUgGFfkxR7DCAkGKC0VvSd3/0OX6PltMPY Ykl3xUO+ef91Wo7b4nQxKP5r/XRZntLRpjL52FnWyBvyLi0WXWSAdpwMSxHsH9PeV8Cn a52yOLxs9nzCsWN/uJJHWyNsSleS6WL42JGHXy745DycJA2xbEIoZhVWzhcWZjIQfOjo PWvg== X-Forwarded-Encrypted: i=1; AJvYcCWLNsRuCC7J8BIW/gcof2CovlnoHaqlN7C67RKZ9ttePYAFk5Hu6zzGg80YQzWQo2ELJxux8iQDuJQ4/rc8TKMjbLTqP5GZlfG5seh/ X-Gm-Message-State: AOJu0YzIy0PMqaXBLMFx9uxk6PPqSmOakpz6ernrzJXkiYAEoeeLf17A pJa1eWU7fwV5mEC9+i9nn+b5PX4nnTmXChGMwTzGwg76W5MV1m4PyaTteMCcFTk= X-Google-Smtp-Source: AGHT+IG2WieA6d2VXCXPEULk6bM4rk8RGnz2VXlb5+XlqbXE2HDHRrkVhtC3A7gynucOeClBzA/BEQ== X-Received: by 2002:a05:6a00:3e1d:b0:705:9a28:aa04 with SMTP id d2e1a72fcca58-70aaaefd5ddmr6625232b3a.23.1719899172664; Mon, 01 Jul 2024 22:46:12 -0700 (PDT) Received: from ghost ([2601:647:5700:6860:a569:328b:99ad:ce17]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70803ecf95bsm7787118b3a.140.2024.07.01.22.46.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 22:46:12 -0700 (PDT) Date: Mon, 1 Jul 2024 22:46:08 -0700 From: Charlie Jenkins To: Samuel Holland Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Heiko Stuebner , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jisheng Zhang , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Jonathan Corbet , Shuah Khan , Guo Ren , Evan Green , Andy Chiu , Jessica Clarke Subject: Re: [PATCH v3 07/13] riscv: csr: Add CSR encodings for VCSR_VXRM/VCSR_VXSAT Message-ID: References: <20240619-xtheadvector-v3-0-bff39eb9668e@rivosinc.com> <20240619-xtheadvector-v3-7-bff39eb9668e@rivosinc.com> <54232f3e-4fea-4996-a90b-6de51e1c51e0@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54232f3e-4fea-4996-a90b-6de51e1c51e0@sifive.com> On Mon, Jul 01, 2024 at 10:49:23AM -0500, Samuel Holland wrote: > Hi Charlie, > > On 2024-06-19 6:57 PM, Charlie Jenkins wrote: > > The VXRM vector csr for xtheadvector has an encoding of 0xa and VXSAT > > has an encoding of 0x9. > > > > Co-developed-by: Heiko Stuebner > > Signed-off-by: Heiko Stuebner > > Signed-off-by: Charlie Jenkins > > --- > > arch/riscv/include/asm/csr.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/riscv/include/asm/csr.h b/arch/riscv/include/asm/csr.h > > index 18e178d83401..9086639a3dde 100644 > > --- a/arch/riscv/include/asm/csr.h > > +++ b/arch/riscv/include/asm/csr.h > > @@ -220,6 +220,8 @@ > > #define VCSR_VXRM_MASK 3 > > #define VCSR_VXRM_SHIFT 1 > > #define VCSR_VXSAT_MASK 1 > > +#define VCSR_VXSAT 0x9 > > +#define VCSR_VXRM 0xa > > These are normal CSR indexes, so the prefix should be just "CSR_". Ok, I can change them. - Charlie > > Regards, > Samuel > > > > > /* symbolic CSR names: */ > > #define CSR_CYCLE 0xc00 > > >