Re: [PATCH v3 2/2] xfs: make xfs_log_iovec independent from xfs_log_vec and free it early

Christoph Hellwig
2024-07-01T04:49:08Z

On Mon, Jul 01, 2024 at 10:51:13AM +1000, Dave Chinner wrote:
> Here's the logic - the iovec array is largely "free" with the larger
> data allocation.

What the patch does it to free the data allocation, that is the shadow
buffer earlier. Which would safe a quite a bit of memory indeed ... if
we didn't expect the shadow buffer to be needed again a little later
anyway, which AFAIK is the assumption under which the CIL code operates.

So as asked previously and by you again here I'd love to see numbers
for workloads where this actually is a benefit.