From: Tejun Heo <tj@kernel.org>
To: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Cc: Xiu Jianfeng <xiujianfeng@huawei.com>,
lizefan.x@bytedance.com, hannes@cmpxchg.org, corbet@lwn.net,
haitao.huang@linux.intel.com, cgroups@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 -next] cgroup/misc: Introduce misc.peak
Date: Wed, 3 Jul 2024 08:03:00 -1000 [thread overview]
Message-ID: <ZoWSVBVAbQjW0l34@slm.duckdns.org> (raw)
In-Reply-To: <cb6bc4b9-bbf3-4d43-aeb8-8efdcbf94a9c@oracle.com>
On Wed, Jul 03, 2024 at 03:13:29PM +0530, Kamalesh Babulal wrote:
...
> The patch looks good to me after the atomic conversion. Sorry for bringing up
> this question so late into the discussion. Given that misc.max is available
> only for non-root cgroups, does it make sense for misc.peak too, available
> for non-root cgroups only?
It's more tied to the usage - misc.current. For memcg, memory.current is
only on non-root cgroups, so is peak. For misc, as misc.current exists for
the root cgroup, it makes sense for .peak to be there too.
Thanks.
--
tejun
next prev parent reply other threads:[~2024-07-03 18:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 0:36 [PATCH v5 -next] cgroup/misc: Introduce misc.peak Xiu Jianfeng
2024-07-03 9:43 ` Kamalesh Babulal
2024-07-03 18:03 ` Tejun Heo [this message]
2024-07-04 5:54 ` Kamalesh Babulal
2024-07-03 18:09 ` Tejun Heo
2024-07-08 11:48 ` Haitao Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoWSVBVAbQjW0l34@slm.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=haitao.huang@linux.intel.com \
--cc=hannes@cmpxchg.org \
--cc=kamalesh.babulal@oracle.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=xiujianfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox