From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6C5D11AAE29; Thu, 4 Jul 2024 09:26:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720085196; cv=none; b=l2izSEnNUAJZaYkW+UtLhNaJKMsEE0jPCPO3XB8zsV0CJPqh0RUWGx1EY2JODMn8gNHyhTZHqZjzJe93DkOwvLEMNxq+8ewHDN5sbockupzajcVZSYwzUF5AcPBHCJmrYMtPNe8bVFHa1uxdYQpgqBKhVzHKuHEgSg3FwYpOR+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720085196; c=relaxed/simple; bh=kK96TeKGcssH878y2ucEpd6cY3M4B7FOVaLWCw4mfVU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I7ufLtArPMPS4/CDBuRJUV0oXp8NZ5LxoFBaQOkapnAx38C4G+kFO08KoKSTYQstm7yr2XbkpQs+pFtCry39ZJSLCrB6I6BeDCHit5D7mJp2E5G6h1Rjab5gU2nUKQ/9LtSlKddB8ZtItOUOuj/pHPsnYl1PwDVzldAx9A7ZH7c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D2C4C367; Thu, 4 Jul 2024 02:26:57 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E27D83F766; Thu, 4 Jul 2024 02:26:27 -0700 (PDT) Date: Thu, 4 Jul 2024 10:26:25 +0100 From: Sudeep Holla To: Viresh Kumar Cc: "Rafael J. Wysocki" , Huang Rui , Sudeep Holla , "Gautham R. Shenoy" , Mario Limonciello , Perry Yuan , Hector Martin , Sven Peter , Alyssa Rosenzweig , Markus Mayer , Broadcom internal kernel review list , Srinivas Pandruvada , Len Brown , Kevin Hilman , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Naveen N. Rao" , Cristian Marussi , Thierry Reding , Jonathan Hunter , Matthias Brugger , AngeloGioacchino Del Regno , linux-pm@vger.kernel.org, Vincent Guittot , Lizhe , linux-kernel@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void Message-ID: References: <3f73fda736818128558b61ad5fe2bed5dce3ddc4.1720075640.git.viresh.kumar@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f73fda736818128558b61ad5fe2bed5dce3ddc4.1720075640.git.viresh.kumar@linaro.org> On Thu, Jul 04, 2024 at 12:23:55PM +0530, Viresh Kumar wrote: > From: Lizhe > > The cpufreq core doesn't check the return type of the exit() callback > and there is not much the core can do on failures at that point. Just > drop the returned value and make it return void. > > Signed-off-by: Lizhe > [ Viresh: Reworked the patches to fix all missing changes together. ] > Signed-off-by: Viresh Kumar > --- [...] > drivers/cpufreq/scmi-cpufreq.c | 4 +--- > drivers/cpufreq/scpi-cpufreq.c | 4 +--- > drivers/cpufreq/vexpress-spc-cpufreq.c | 5 ++--- (For the above 3 files) Acked-by: Sudeep Holla -- Regards, Sudeep