Re: [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void

Mario Limonciello
2024-07-04T11:56:32Z

On 7/4/2024 1:53, Viresh Kumar wrote:
> From: Lizhe <sensor1010@163.com>
>
> The cpufreq core doesn't check the return type of the exit() callback
> and there is not much the core can do on failures at that point. Just
> drop the returned value and make it return void.
>
> Signed-off-by: Lizhe <sensor1010@163.com>
> [ Viresh: Reworked the patches to fix all missing changes together. ]
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/cpufreq/acpi-cpufreq.c | 4 +---
> drivers/cpufreq/amd-pstate.c | 7 ++-----
> drivers/cpufreq/apple-soc-cpufreq.c | 4 +---
> drivers/cpufreq/bmips-cpufreq.c | 4 +---
> drivers/cpufreq/cppc_cpufreq.c | 3 +--
> drivers/cpufreq/cpufreq-dt.c | 3 +--
> drivers/cpufreq/e_powersaver.c | 3 +--
> drivers/cpufreq/intel_pstate.c | 8 +++-----
> drivers/cpufreq/mediatek-cpufreq-hw.c | 4 +---
> drivers/cpufreq/mediatek-cpufreq.c | 4 +---
> drivers/cpufreq/omap-cpufreq.c | 3 +--
> drivers/cpufreq/pasemi-cpufreq.c | 6 ++----
> drivers/cpufreq/powernow-k6.c | 5 ++---
> drivers/cpufreq/powernow-k7.c | 3 +--
> drivers/cpufreq/powernow-k8.c | 6 ++----
> drivers/cpufreq/powernv-cpufreq.c | 4 +---
> drivers/cpufreq/ppc_cbe_cpufreq.c | 3 +--
> drivers/cpufreq/qcom-cpufreq-hw.c | 4 +---
> drivers/cpufreq/qoriq-cpufreq.c | 4 +---
> drivers/cpufreq/scmi-cpufreq.c | 4 +---
> drivers/cpufreq/scpi-cpufreq.c | 4 +---
> drivers/cpufreq/sh-cpufreq.c | 4 +---
> drivers/cpufreq/sparc-us2e-cpufreq.c | 3 +--
> drivers/cpufreq/sparc-us3-cpufreq.c | 3 +--
> drivers/cpufreq/speedstep-centrino.c | 10 +++-------
> drivers/cpufreq/tegra194-cpufreq.c | 4 +---
> drivers/cpufreq/vexpress-spc-cpufreq.c | 5 ++---
> include/linux/cpufreq.h | 2 +-
> 28 files changed, 37 insertions(+), 84 deletions(-)

Acked-by: Mario Limonciello <mario.limonciello@amd.com> #
drivers/cpufreq/amd-pstate.c