Re: [PATCH v5 2/7] dt-bindings: firmware: add i.MX95 SCMI Extension protocol

Cristian Marussi
2024-07-11T13:05:10Z

On Fri, Jun 21, 2024 at 03:04:37PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>

LGTM.
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>

Thanks,
Cristian

> Add i.MX SCMI Extension protocols bindings for:
> - Battery Backed Module(BBM) Protocol
> This contains persistent storage (GPR), an RTC, and the ON/OFF button.
> The protocol can also provide access to similar functions implemented via
> external board components.
> - MISC Protocol.
> This includes controls that are misc settings/actions that must be exposed
> from the SM to agents. They are device specific and are usually define to
> access bit fields in various mix block control modules, IOMUX_GPR, and
> other GPR/CSR owned by the SM.
>
> Reviewed-by: "Rob Herring (Arm)" <robh@kernel.org>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> .../devicetree/bindings/firmware/arm,scmi.yaml | 5 ++-
> .../bindings/firmware/nxp,imx95-scmi.yaml | 43 ++++++++++++++++++++++
> 2 files changed, 47 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> index 4d823f3b1f0e..47f0487e35de 100644
> --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> @@ -22,6 +22,9 @@ description: |
>
> [0] https://developer.arm.com/documentation/den0056/latest
>
> +anyOf:
> + - $ref: /schemas/firmware/nxp,imx95-scmi.yaml
> +
> properties:
> $nodename:
> const: scmi
> @@ -284,7 +287,7 @@ properties:
> required:
> - reg
>
> -additionalProperties: false
> +unevaluatedProperties: false
>
> $defs:
> protocol-node:
> diff --git a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml
> new file mode 100644
> index 000000000000..1a95010a546b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright 2024 NXP
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/firmware/nxp,imx95-scmi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: i.MX95 System Control and Management Interface(SCMI) Vendor Protocols Extension
> +
> +maintainers:
> + - Peng Fan <peng.fan@nxp.com>
> +
> +properties:
> + protocol@81:
> + $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node'
> + unevaluatedProperties: false
> +
> + properties:
> + reg:
> + const: 0x81
> +
> + protocol@84:
> + $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node'
> + unevaluatedProperties: false
> +
> + properties:
> + reg:
> + const: 0x84
> +
> + nxp,ctrl-ids:
> + description:
> + Each entry consists of 2 integers, represents the ctrl id and the value
> + items:
> + items:
> + - description: the ctrl id index
> + enum: [0, 1, 2, 3, 4, 5, 6, 7, 0x8000, 0x8001, 0x8002, 0x8003,
> + 0x8004, 0x8005, 0x8006, 0x8007]
> + - description: the value assigned to the ctrl id
> + minItems: 1
> + maxItems: 16
> + $ref: /schemas/types.yaml#/definitions/uint32-matrix
> +
> +additionalProperties: true
>
> --
> 2.37.1
>