Re: [PATCH v5 0/7] firmware: support i.MX95 SCMI BBM/MISC Extenstion

Alexandre Belloni
2024-07-11T19:54:46Z

On 11/07/2024 15:05:42+0100, Cristian Marussi wrote:
> On Fri, Jun 21, 2024 at 03:04:35PM +0800, Peng Fan (OSS) wrote:
> > i.MX95 System Manager Firmware source: https://github.com/nxp-imx/imx-sm
> > To generate html from the repo: make html
> >
>
> Hi Peng,
>
> thanks for upstreaming this Vendor protocol.

The question being when are they going to reuse the protocols, we
already have two just from nxp:

rtc-nxp-bbnsm.c
rtc-imx-sc.c

>
> LGTM, beside minor nitpicks I mentioned.
>
> Please run checkpatch.pl --strict on series before next rebase, though,
> that I spotted a few minor not-so-stylish things :D
>
> Thanks,
> Cristian

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering