From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Huacai Chen <chenhuacai@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Serge Semin <fancer.lancer@gmail.com>,
"paulburton@kernel.org" <paulburton@kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/10] MIPS: smp: Manage IPI interrupts as percpu_devid interrupts
Date: Thu, 4 Jul 2024 15:05:21 +0200 [thread overview]
Message-ID: <ZoaeEYdEmEBl6R7J@alpha.franken.de> (raw)
In-Reply-To: <fdedcd38-4688-4938-9184-2eaa5dedeb43@app.fastmail.com>
On Thu, Jul 04, 2024 at 04:08:09AM +0800, Jiaxun Yang wrote:
>
>
> 在2024年7月3日七月 下午11:03，Thomas Bogendoerfer写道：
> [...]
> >
> > there is no user of mips_smp_ipi_disable() (at least I didn't see one),
> > so do we need this patch at all ? Just looking like ARM or RiscV isn't
> > a justification for code churn.
>
> Hi Thomas,
>
> The per-cpu enablement process is necessary for IPI_MUX and
> my upcoming IPI driver.
>
> The disablement, I'm not really sure, maybe it's a good idea to call it at
> platform's __cpu_disable to prevent spurious IPI after IRQ migration.
don't add dead code, so drop mips_smp_ipi_disable() for now.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2024-07-04 13:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-16 21:03 [PATCH 00/10] MIPS: IPI Improvements Jiaxun Yang
2024-06-16 21:03 ` [PATCH 01/10] MIPS: smp: Make IPI interrupts scalable Jiaxun Yang
2024-07-03 15:04 ` Thomas Bogendoerfer
2024-07-03 20:15 ` Jiaxun Yang
2024-07-03 21:26 ` Maciej W. Rozycki
2024-07-03 22:07 ` Jiaxun Yang
2024-07-04 14:34 ` Florian Fainelli
2024-07-04 22:36 ` Maciej W. Rozycki
2024-07-05 6:55 ` Thomas Bogendoerfer
2024-07-04 13:14 ` Thomas Bogendoerfer
2024-07-05 8:40 ` Serge Semin
2024-07-05 9:08 ` Jiaxun Yang
2024-06-16 21:03 ` [PATCH 02/10] MIPS: smp: Manage IPI interrupts as percpu_devid interrupts Jiaxun Yang
2024-07-03 15:03 ` Thomas Bogendoerfer
2024-07-03 20:08 ` Jiaxun Yang
2024-07-04 13:05 ` Thomas Bogendoerfer [this message]
2024-06-16 21:03 ` [PATCH 03/10] MIPS: smp: Provide platform IPI virq & domain hooks Jiaxun Yang
2024-06-16 21:03 ` [PATCH 04/10] MIPS: Move mips_smp_ipi_init call after prepare_cpus Jiaxun Yang
2024-06-17 13:53 ` Huacai Chen
2024-06-17 22:10 ` Jiaxun Yang
2024-06-18 3:51 ` Huacai Chen
2024-06-18 14:50 ` Jiaxun Yang
2024-07-03 15:09 ` Thomas Bogendoerfer
2024-06-16 21:03 ` [PATCH 05/10] MIPS: smp: Implement IPI stats Jiaxun Yang
2024-07-03 15:11 ` Thomas Bogendoerfer
2024-06-16 21:03 ` [PATCH 06/10] irqchip: irq-mips-gic: Switch to ipi_mux Jiaxun Yang
2024-06-16 21:03 ` [PATCH 07/10] MIPS: Implement get_mips_sw_int hook Jiaxun Yang
2024-06-16 21:03 ` [PATCH 08/10] MIPS: GIC: Implement get_sw_int hook Jiaxun Yang
2024-06-16 21:03 ` [PATCH 09/10] irqchip: irq-mips-cpu: Rework software IRQ handling flow Jiaxun Yang
2024-06-16 21:03 ` [PATCH 10/10] MIPS: smp-mt: Rework IPI functions Jiaxun Yang
2024-07-03 8:37 ` [PATCH 00/10] MIPS: IPI Improvements Jiaxun Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoaeEYdEmEBl6R7J@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=chenhuacai@kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paulburton@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox