Re: [PATCH 01/10] MIPS: smp: Make IPI interrupts scalable

Jiaxun Yang
2024-07-05T09:09:16Z

在2024年7月5日七月 下午4:40，Serge Semin写道：
> Hi folks,
>
> On Wed, Jul 03, 2024 at 05:04:49PM +0200, Thomas Bogendoerfer wrote:
>> On Sun, Jun 16, 2024 at 10:03:05PM +0100, Jiaxun Yang wrote:
>> > Define enum ipi_message_type as other architectures did to
>> > allow easy extension to number of IPI interrupts, fiddle
>> > around platform IPI code to adopt to the new infra, add
>> > extensive BUILD_BUG_ON on IPI numbers to ensure future
>> > extensions won't break existing platforms.
>> >
>> > IPI related stuff are pulled to asm/ipi.h to avoid include
>> > linux/interrupt.h in asm/smp.h.
>> >
>> > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> > ---
>> > arch/mips/cavium-octeon/smp.c | 109 ++++++++++++-----------------------
>> > arch/mips/include/asm/ipi.h | 34 +++++++++++
>> > arch/mips/include/asm/smp-ops.h | 8 +--
>> > arch/mips/include/asm/smp.h | 42 ++++++--------
>> > arch/mips/kernel/smp-bmips.c | 43 +++++++-------
>> > arch/mips/kernel/smp-cps.c | 1 +
>> > arch/mips/kernel/smp.c | 124 ++++++++++++++++++++--------------------
>> > arch/mips/loongson64/smp.c | 51 +++++++++--------
>> > arch/mips/mm/c-octeon.c | 2 +-
>> > arch/mips/sgi-ip27/ip27-smp.c | 15 +++--
>> > arch/mips/sgi-ip30/ip30-smp.c | 15 +++--
>> > arch/mips/sibyte/bcm1480/smp.c | 19 +++---
>> > arch/mips/sibyte/sb1250/smp.c | 13 +++--
>> > 13 files changed, 236 insertions(+), 240 deletions(-)
>>
>> you are touching a lot of platforms, how many did you test ?
>
> In a one or two days I'll be able to test the series on the SoC with
> 2x MIPS P5600 Warrior.

Thanks everyone for the collaborative effort, I’m impressed!

Will respin this series later today.

Thanks
>
> -Serge(y)
>
>>
>> Thomas.
>>
>> --
>> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
>> good idea. [ RFC1925, 2.3 ]

--
- Jiaxun