Re: [PATCH 04/10] MIPS: Move mips_smp_ipi_init call after prepare_cpus

Thomas Bogendoerfer
2024-07-03T15:13:05Z

On Tue, Jun 18, 2024 at 03:50:33PM +0100, Jiaxun Yang wrote:
>
>
> 在2024年6月18日六月 上午4:51，Huacai Chen写道：
> > On Tue, Jun 18, 2024 at 6:10 AM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
> >>
> >>
> >>
> >> 在2024年6月17日六月 下午2:53，Huacai Chen写道：
> >> > Hi, Jiaxun
> >> >
> >> > On Mon, Jun 17, 2024 at 5:03 AM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
> >> >>
> >> >> This will give platform code a genuine chance to setup
> >> >> IPI IRQ in prepare_cpus.
> >> >>
> >> >> This is the best place for platforms to setup IPI as smp_setup
> >> >> is too early for IRQ subsystem.
> >> > mips_smp_ipi_init() is an early_initcall() function, why do you say it
> >> > is in smp_setup()?
> >>
> >> Sorry, I was trying to say that smp_setup is not a good point so we should
> >> go prepare_cpus.
> > It is not in smp_setup() now, then how do you move it from smp_setup()?
> [...]
>
> Well I was trying to justify where should I move it to, not where
> does it from.
>
> I should improve the commit message to justify the reason first.

please do

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]