From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5CE1848A; Fri, 5 Jul 2024 01:55:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720144536; cv=none; b=rQR0qheVG9Zcalp4PQcOIvf/cy4G9NwFJLW+/GF2W5bPpVyW9QnXdrl07Z8yB8FiFpHKAOQVgBdb6/F7OiFE48sFWagRV01HF7tSUCDSydj8dVbZN0wKxyssyIAiGHR/StnCqmND1E3ZmWZZ7dxL5geT2AINYAlKaeZDNY4ak9c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720144536; c=relaxed/simple; bh=0D07LHAuhhUTF8PFmdgBLlE7Wo0dLVb51mBbu1HxwUc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c39l1tqYm59K/1gGHmhRdU1zX81WhMy0aJk/cuPcaBwX5ZagMRyHAZf/i7Ck3PpDr/0/WgIfPmbQs+LMVEjGJgmH+JgU8Fwu+dx8B2hf9nlffumzmbODtKdD119eLQzP3mrtaiaFctm4goU5e0b3dKOVFculYb++zC3ZLuuUnio= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jWZ3cyr9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jWZ3cyr9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16279C3277B; Fri, 5 Jul 2024 01:55:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720144536; bh=0D07LHAuhhUTF8PFmdgBLlE7Wo0dLVb51mBbu1HxwUc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jWZ3cyr9YnRQMnZhzLP9jJLxSHLjRfogDBprSaFxMbke0qmX+aSZyZhZlYmljrGI6 yV+pa+5jjjxKmPyzz5fKdqWdAgPJ56Kvd8CLWWl602mid+IdsoTmoy0Dsw8CyLMpao 3sNC+iHe2icjtFQFXOFJ/Yac+Bt6290hN2mbCKIZeA09i5OI08y17285J5DtsCO1Jk thYvotCStwHBVioNRLL0qLC2J8aRWPB07gbEpdKGWUd2ePOnHRGoGt75ArI5p87c8P m4DO5PJI7G1lBT5w5ZdY/EdORiND0BFhEH/xNhmqFsnO/Z05tjue9vLcG//cpOHLQ0 68bbZCmFZ1taw== Date: Fri, 5 Jul 2024 01:55:31 +0000 From: Tzung-Bi Shih To: Dan Carpenter Cc: Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Benson Leung , Guenter Roeck , Sebastian Reichel , chrome-platform@lists.linux.dev, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] power: supply: cros_charge-control: Fix signedness bug in charge_behaviour_store() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jul 04, 2024 at 10:20:03AM -0500, Dan Carpenter wrote: > The C standard is vague about the signedness of enums, but in this case > here, they are treated as unsigned so the error handling does not work. > Use an int type to fix this. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next Thanks! [1/1] power: supply: cros_charge-control: Fix signedness bug in charge_behaviour_store() commit: 4baf1cc54433ff7c6e5178517bc8768001416681