From: Johan Hovold <johan@kernel.org>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH v2 0/2] USB: serial: garmin_gps: annotate struct garmin_packet with __counted_by
Date: Fri, 5 Jul 2024 14:04:21 +0200 [thread overview]
Message-ID: <ZofhReiVQ3k8IaFy@hovoldconsulting.com> (raw)
In-Reply-To: <20240619-garmin_gps_counted_by-v2-0-f82f10ebbf28@gmail.com>
On Wed, Jun 19, 2024 at 09:42:43PM +0200, Javier Carrasco wrote:
> The size is assigned before the first reference to the flexible array
> (see pkt_add()), which allows for a straightforward annotation without
> further modifications.
>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
> Changes in v2:
> - Use struct_size to calculate the size of pkt.
> - Link to v1: https://lore.kernel.org/r/20240619-garmin_gps_counted_by-v1-1-d8d816f085d9@gmail.com
>
> ---
> Javier Carrasco (2):
> USB: serial: garmin_gps: annotate struct garmin_packet with __counted_by
> USB: serial: garmin_gps: use struct_size to allocate pkt
Now applied (after adding parentheses to struct_size() in the summary).
Johan
prev parent reply other threads:[~2024-07-05 12:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 19:42 [PATCH v2 0/2] USB: serial: garmin_gps: annotate struct garmin_packet with __counted_by Javier Carrasco
2024-06-19 19:42 ` [PATCH v2 1/2] " Javier Carrasco
2024-06-19 19:56 ` Gustavo A. R. Silva
2024-06-19 20:34 ` Kees Cook
2024-06-19 19:42 ` [PATCH v2 2/2] USB: serial: garmin_gps: use struct_size to allocate pkt Javier Carrasco
2024-06-19 19:55 ` Gustavo A. R. Silva
2024-06-19 20:33 ` Kees Cook
2024-07-05 12:04 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZofhReiVQ3k8IaFy@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox