From: Jeff LaBundy <jeff@labundy.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org,
Benjamin Tissoires <bentiss@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 7/7] Input: do not check number of events in input_pass_values()
Date: Sun, 7 Jul 2024 14:57:24 -0500 [thread overview]
Message-ID: <ZorzJNnQKXoWE+wr@nixie71> (raw)
In-Reply-To: <20240703213756.3375978-8-dmitry.torokhov@gmail.com>
Hi Dmitry,
On Wed, Jul 03, 2024 at 02:37:54PM -0700, Dmitry Torokhov wrote:
> Now that the input_dev->vals array is always there we can be assured
> that input_pass_values() is always called with a non-0 number of
> events. Remove the check.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Jeff LaBundy <jeff@labundy.com>
> ---
> drivers/input/input.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/input/input.c b/drivers/input/input.c
> index 4e12fa79883e..54c57b267b25 100644
> --- a/drivers/input/input.c
> +++ b/drivers/input/input.c
> @@ -115,9 +115,6 @@ static void input_pass_values(struct input_dev *dev,
>
> lockdep_assert_held(&dev->event_lock);
>
> - if (!count)
> - return;
> -
> rcu_read_lock();
>
> handle = rcu_dereference(dev->grab);
> --
> 2.45.2.803.g4e1b14247a-goog
>
Kind regards,
Jeff LaBundy
next prev parent reply other threads:[~2024-07-07 19:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 21:37 [PATCH v2 0/7] Simplify event handling logic in input core Dmitry Torokhov
2024-07-03 21:37 ` [PATCH v2 1/7] Input: evdev - remove ->event() method Dmitry Torokhov
2024-07-07 19:53 ` Jeff LaBundy
2024-07-03 21:37 ` [PATCH v2 2/7] Input: make sure input handlers define only one processing method Dmitry Torokhov
2024-07-07 19:53 ` Jeff LaBundy
2024-07-03 21:37 ` [PATCH v2 3/7] Input: make events() method return number of events processed Dmitry Torokhov
2024-07-07 19:54 ` Jeff LaBundy
2024-07-03 21:37 ` [PATCH v2 4/7] Input: simplify event handling logic Dmitry Torokhov
2024-07-07 19:55 ` Jeff LaBundy
2024-07-03 21:37 ` [PATCH v2 5/7] Input: rearrange input_alloc_device() to prepare for preallocating of vals Dmitry Torokhov
2024-07-07 19:56 ` Jeff LaBundy
2024-07-03 21:37 ` [PATCH v2 6/7] Input: preallocate memory to hold event values Dmitry Torokhov
2024-07-07 19:56 ` Jeff LaBundy
2024-07-03 21:37 ` [PATCH v2 7/7] Input: do not check number of events in input_pass_values() Dmitry Torokhov
2024-07-07 19:57 ` Jeff LaBundy [this message]
2024-07-04 6:44 ` [PATCH v2 0/7] Simplify event handling logic in input core Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZorzJNnQKXoWE+wr@nixie71 \
--to=jeff@labundy.com \
--cc=bentiss@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox