From: Christoph Hellwig <hch@infradead.org>
To: George Stark <gnstark@salutedevices.com>
Cc: linux-kernel@vger.kernel.org, kernel@salutedevices.com
Subject: Re: [PATCH 1/1] initrd: use O_SYNC flag while opening /dev/ram for write
Date: Mon, 8 Jul 2024 23:03:00 -0700 [thread overview]
Message-ID: <ZozSlCGyKCkj3uUl@infradead.org> (raw)
In-Reply-To: <20240708200923.1824270-1-gnstark@salutedevices.com>
On Mon, Jul 08, 2024 at 11:09:23PM +0300, George Stark wrote:
> initrd image is written to the /dev/ram block device using filp_open(),
> kernel_write()
First question: why are you using the legacy initrd and not initramfs?
> . After fput() /dev/ram is mounted and may fail due to not
> all data is actually written to the device yet. The mount error remains
> hidden due to MS_SILENT flag usage and mount_root_generic has retries.
> So use O_SYNC flag to have all data written to /dev/ram before mounting.
O_SYNC is highly inefficient. If you have a valid reason to care about
a corner case in the hopefully soon to be remvoved legacy initrd code,
the right way to do this is a single fdatasync after the writes have
finished.
next prev parent reply other threads:[~2024-07-09 6:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 20:09 [PATCH 1/1] initrd: use O_SYNC flag while opening /dev/ram for write George Stark
2024-07-09 6:03 ` Christoph Hellwig [this message]
2024-07-09 16:18 ` George Stark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZozSlCGyKCkj3uUl@infradead.org \
--to=hch@infradead.org \
--cc=gnstark@salutedevices.com \
--cc=kernel@salutedevices.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox