From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92B0D1662E8 for ; Sun, 21 Jul 2024 16:40:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721580010; cv=none; b=DuVjevpvpAELgSFpsZ1m7xsrvfPvAyb/TWP499GyEvh3h9QDe30mAVAHXGeapovsFrFIBETm4PtF2O6yBEaFgMUooBlW39EGvFHF1uKsSEyVJPL6ZWefPghCCKYZ7OWb6c5WuZsQnpuEQPBKUElN0zwAtxm0nYsEts4BPMcJl5Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721580010; c=relaxed/simple; bh=5GBs3sS6GffttYb1SH6OSACa7GZ+aq5K6lp0mClKlYk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cuYWwimtC0zyFovQp+ShBmuKnP2CnJ+ysp/8U5qtaqwJdDEFhE2o7A4O9fc8gkcyTAP9YabetI0fqLa04iQXPlC4gWuSOMA7+kDnkyMXQluhCR28zR9yPQRY4SXjllcsxEGYqCir8G3tjPVHS4cTPtBF1p7nFkn6i6o/y2m160Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CgWbvpfr; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CgWbvpfr" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4279c10a40eso25183325e9.3 for ; Sun, 21 Jul 2024 09:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721580007; x=1722184807; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dt8rut9OoDlVFuaG7w8NWKSMFr7P+aJevTWLxUH5VX8=; b=CgWbvpfrMOY0o1T3xQIa3PVfxofHcxVMUOu2275LeZi+76cCo6Qh/YJs32wIoVkdxO L2PsSlwpJHzNA+9yAxvAysN23ePBpRn2HF6Q7QZx/URXRkZ5ofCZx3FlpATW855ehyNE NwCRZFabI5N/J3vUgLV/PpnMnQN/cnBDMDNwHY4+PC/u0GZhttVvJspjFP+9lig0VohU sBDoGi/+phNtEkofjICnEg69XhjiUuxOJVJ0nRbJaJEOZJ9B6ly6FcUo5TrYRb0zw6Ol 7YgcHFgZ+P4wJ6xAfg65j2rJHMs1BA2qelUdv7nxDmTzuYy1OWQ0gh5oFcjDJAYJVtMT MTAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721580007; x=1722184807; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dt8rut9OoDlVFuaG7w8NWKSMFr7P+aJevTWLxUH5VX8=; b=bNobFQ+3RmAdDyULwtX2LQ0BlkTSiqK2KZRnxxQQrIuKXjCYh1/rJgeD1UxQLgHxNZ 94P5kAgN8TIOSZ+26p+f2tqPrMFBA7HINOb/RvKq+7JMZ33gKqD4tSv9wRb3HejM9oUI EhVBr//qMO6nywFHJwqFo29hgAFDZlbOCSGvYluRE0Z5Npw6ZXl/psCKc9uxBwkXQeyu iYl5K2soMbCkhwfmP7mIO6l9ZGiIIwSTxShmpm3WPj1Vvcnc9ElCCgEdLuBMbv2kMZR3 uNeE/FsztwBJMygnnvg1PZhnrPmBJRSfnYrLgU4RqVjnV+lfJ3SimNhmK5EJIMLVVamo QM8g== X-Forwarded-Encrypted: i=1; AJvYcCXmzAlMkm0GjxQ+YZLsvnulvWh1xSNB+1EDu9amD3sRIV/RVRB04DPBQHuSGnLmqIaqlImwWq++NMBC+ej4L/accZdJirQI1x1DTVdn X-Gm-Message-State: AOJu0YyFfWD03zAoXqaQiQHRQ+GqzzrRnuVFN4vyIgSaLeK4F5ZEbrqe y4m8znqm0KwBymD5pJDv0JyIWk1Hhix25ziSX3ZWZCiN8schYq//r9MjtF70h2QbXWbjS9ASqWo l X-Google-Smtp-Source: AGHT+IFtPWfr7OsTINMHDSjbMnUGeIDJIlJTbz6Wnqqsq1eR5dWUmlV4w7BEk6oGYCE1FbS8+uBP6A== X-Received: by 2002:a5d:498e:0:b0:368:6678:f792 with SMTP id ffacd0b85a97d-369bae6ff45mr2040076f8f.39.1721580006891; Sun, 21 Jul 2024 09:40:06 -0700 (PDT) Received: from linaro.org ([82.79.124.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-368787cedabsm6313292f8f.84.2024.07.21.09.40.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jul 2024 09:40:06 -0700 (PDT) Date: Sun, 21 Jul 2024 19:40:04 +0300 From: Abel Vesa To: Konrad Dybcio Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: Re: [PATCH 3/3] arm64: dts: qcom: Add X1E78100 ThinkPad T14s Gen 6 Message-ID: References: <20240719-topic-t14s_upstream-v1-0-d7d97fdebb28@linaro.org> <20240719-topic-t14s_upstream-v1-3-d7d97fdebb28@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240719-topic-t14s_upstream-v1-3-d7d97fdebb28@linaro.org> On 24-07-19 22:16:38, Konrad Dybcio wrote: > Add support for the aforementioned laptop. That includes: > > - input methods, incl. lid switch (keyboard needs the pdc > wakeup-parent removal hack..) > - NVMe, WiFi > - USB-C ports > - GPU, display > - DSPs > > Notably, the USB-A ports on the side are depenedent on the USB > multiport controller making it upstream. > > At least one of the eDP panels used (non-touchscreen) identifies as > BOE 0x0b66. > > See below for the hardware description from the OEM. > > Link: https://www.lenovo.com/us/en/p/laptops/thinkpad/thinkpadt/lenovo-thinkpad-t14s-gen-6-(14-inch-snapdragon)/len101t0099 > Signed-off-by: Konrad Dybcio Few comments below. Otherwise, LGTM. Reviewed-by: Abel Vesa > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 792 +++++++++++++++++++++ > 2 files changed, 793 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 0e5c810304fb..734a05e04c4a 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -261,6 +261,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8650-hdk-display-card.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8650-hdk.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8650-mtp.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8650-qrd.dtb > +dtb-$(CONFIG_ARCH_QCOM) += x1e78100-lenovo-thinkpad-t14s.dtb > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-asus-vivobook-s15.dtb > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-crd.dtb > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-lenovo-yoga-slim7x.dtb > diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts So what happens for SKUs of this model wil have x1e80100 ? Maybe we should stick to x1e80100 ? > new file mode 100644 > index 000000000000..b12953267505 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts > @@ -0,0 +1,792 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved. > + * Copyright (c) 2024, Linaro Limited > + */ > + > +/dts-v1/; > + > +#include > +#include > +#include > +#include > + > +#include "x1e80100.dtsi" > +#include "x1e80100-pmics.dtsi" > + > +/ { > + model = "Lenovo ThinkPad T14s Gen 6"; > + compatible = "lenovo,thinkpad-t14s", "qcom,x1e78100", "qcom,x1e80100"; > + > + aliases { > + serial0 = &uart21; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + [...] > + > + vreg_edp_3p3: regulator-edp-3p3 { > + compatible = "regulator-fixed"; > + > + regulator-name = "VREG_EDP_3P3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + gpio = <&tlmm 70 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-0 = <&edp_reg_en>; > + pinctrl-names = "default"; > + > + regulator-always-on; Drop this. > + regulator-boot-on; > + }; > + [...] > + > +&tlmm { > + gpio-reserved-ranges = <34 2>, /* Unused */ > + <44 4>, /* SPI (TPM) */ > + <72 2>, /* Secure EC I2C connection (?) */ > + <238 1>; /* UFS Reset */ > + > + tpad_default: tpad-default-state { > + pins = "gpio3"; > + function = "gpio"; > + bias-pull-up; > + }; > + > + nvme_reg_en: nvme-reg-en-state { > + pins = "gpio18"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + ts0_default: ts0-default-state { > + reset-n-pins { > + pins = "gpio48"; > + function = "gpio"; > + output-high; > + drive-strength = <16>; > + }; > + > + int-n-pins { > + pins = "gpio51"; > + function = "gpio"; > + bias-disable; > + }; > + }; > + > + kybd_default: kybd-default-state { > + pins = "gpio67"; > + function = "gpio"; > + bias-disable; > + }; > + > + edp_reg_en: edp-reg-en-state { > + pins = "gpio70"; > + function = "gpio"; > + drive-strength = <16>; > + bias-pull-up; bias-disable, maybe ? > + }; > + > + hall_int_n_default: hall-int-n-state { > + pins = "gpio92"; > + function = "gpio"; > + bias-disable; > + }; > + [...] > > -- > 2.45.2 >