Re: [PATCH v2 2/2] arm64: dts: qcom: x1e80100-yoga: Update panel bindings

Rob Clark
2024-07-22T14:37:19Z

On Mon, Jul 22, 2024 at 12:15 AM Stephan Gerhold
<stephan.gerhold@linaro.org> wrote:
>
> On Fri, Jul 19, 2024 at 11:52:50AM -0700, Rob Clark wrote:
> > From: Rob Clark <robdclark@chromium.org>
> >
> > Use the correct panel compatible, and wire up enable-gpio. It is wired
> > up in the same way as the x1e80100-crd.
> >
> > Signed-off-by: Rob Clark <robdclark@chromium.org>
> > ---
> > .../boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 13 ++++++++++++-
> > 1 file changed, 12 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> > index f569f0fbd1fc..28a6ea5a24fd 100644
> > --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> > +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> > @@ -592,9 +592,13 @@ &mdss_dp3 {
> >
> > aux-bus {
> > panel {
> > - compatible = "edp-panel";
> > + compatible = "samsung,atna45dc02", "samsung,atna33xc20";
> > + enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>;
> > power-supply = <&vreg_edp_3p3>;
> >
> > + pinctrl-0 = <&edp_bl_en>;
> > + pinctrl-names = "default";
> > +
> > port {
> > edp_panel_in: endpoint {
> > remote-endpoint = <&mdss_dp3_out>;
> > @@ -663,6 +667,13 @@ &pcie6a_phy {
> > status = "okay";
> > };
> >
> > +&pmc8380_3_gpios {
> > + edp_bl_en: edp-bl-en-state {
> > + pins = "gpio4";
> > + function = "normal";
> > + };
>
> Did you omit the "power-source" here on purpose? It works without
> because the firmware already configures this pin, but ideally we should
> provide the full configuration.

I just copied the CRD.. other than the panel, things appear to be
wired up in the same way.

BR,
-R

> In /sys/kernel/debug/gpio you can check how the firmware has configured
> the pin. It is probably exactly the same as for the CRD.
>
> Thanks,
> Stephan