From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 869EC262A3 for ; Mon, 22 Jul 2024 10:08:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721642887; cv=none; b=JkFbNpcXodZZT4LjWLpEoey7BTm3f5CRP64XdVwGHV6IPxRFARvvUN/RBnHjjhsCk4519IxCnbVnAmU/9O1ZkiXf6aybkOhRKDKsHGL9NjXQaouAZtMPMKW2JCAF3UvOQAgUfh2ypSsakN2j0zeMs9SqbqYHtEVUkeRZ3vnM6IY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721642887; c=relaxed/simple; bh=r1loaNoaVzUz0Y58T1NxG2CyminGBJ5gUFgU+IPEIRI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LFqFpslHxCA5hWyxmqjBew2rOu0dC+S2h9t3wdSGPACkQ5qCol8A2Ayw3HZrukaWZs0PoTwnkUFkNFQAkDc3MQix+Cdf2bYxCZXXKTfPh/sz1NEU/xNYium+49fGy3p92W5Zz7dmuQLPP1K3GOjMseBQUweD0NtDP5JM28TuWXM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=N14jcNwU; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N14jcNwU" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-427d2cc1c4eso28751465e9.1 for ; Mon, 22 Jul 2024 03:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721642884; x=1722247684; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=K3Uk/HnGYvHiGjn0UJ5Gko3LyCdJekB5KAmj2kPnYgU=; b=N14jcNwU4vERTn0k4gaJvPVk9iUT64Mh1R9y6WAegLMA5NG4d4k+f+4bB/WG35tov2 19PLx38cUrr7jKesPTE+TZir4FqycP3ad2wLxfhWV39JMnq+GZhG//e3Ah7ntyBK6HVz q//jOTWdmFlYuTdtBYVXTKycFZwBf164ANAK+JOGFckPGyJgFtro8Rvd/HP9bHErJ6dU Fh99HJr+s1OvUQstFcy+BLD8exgyZtXXlVHqcayNLx6y5qkQ3t3to7cqBkMFINpkdhDU u1fnj2BVUMdT+yC2Sl2As3u3jDe4mYV+1UosIu6PWj37SNVZ4Ev2Z5F8Qs0E3xr88QBw V6JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721642884; x=1722247684; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K3Uk/HnGYvHiGjn0UJ5Gko3LyCdJekB5KAmj2kPnYgU=; b=pzmIRLX/EGAQsoCHvqK93RdVS9IiFMAxg1Zshd0+2QmQzwUvgr0vxHYLBhX8HF6VLF NYrMv0P/L4s16HpIQi6DoQ6LaPftfs0xyGARGYnNVn6pWqfGxkk5bm2lUOfdrE1oDax+ ak2cM97gN2rN041nncR6W/cORMGoSjGKwn7QtbzZJj0aSjlwUyt1Mu2OdOhNhvRxgm/X F2CHTNHkmNL5hcZdLdmjHAosyMoo0MzScXSMRLMkB7FvrJn1WvVmNnishTSuLz7CW3Wc U11/qGbBQ5478GTAwx5e83RpqSfetvmYDyxi88G3MVZju4jjzTVzIKNOXLtWYiQ/gQY1 9QUg== X-Forwarded-Encrypted: i=1; AJvYcCXe9hj5vohL83i575maiBSy/LxRoRsqRFhyDDeLeJl54kEkTnUd2hlhPE6Lw2pGn9gIIdbXYLHsdiDdcYsv5ryA6kmqvD7xdd5/2ULp X-Gm-Message-State: AOJu0YzjMPWb9rfy0k+0ZS5fE6OCJu/12WmuZawK0eDMESxt5JLJiWxk Xvvcgpg1tvqzynq6rCkkJyJhHX6tPZRc50t37+KsOD6d7bQlqPRsXf/19+6qQoE= X-Google-Smtp-Source: AGHT+IFIXBJGfP5zn3Csiw0GWYfvIZCoJ0/uv1/GU+SfszljWg0XRCD5mUABvDoCw0+lfOvDWEknhw== X-Received: by 2002:a05:600c:83cc:b0:426:62a0:eb6b with SMTP id 5b1f17b1804b1-427dc529244mr42147605e9.13.1721642883926; Mon, 22 Jul 2024 03:08:03 -0700 (PDT) Received: from linaro.org ([82.79.124.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427d6929976sm121953845e9.29.2024.07.22.03.08.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jul 2024 03:08:03 -0700 (PDT) Date: Mon, 22 Jul 2024 13:08:02 +0300 From: Abel Vesa To: Konrad Dybcio Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: Re: [PATCH 3/3] arm64: dts: qcom: Add X1E78100 ThinkPad T14s Gen 6 Message-ID: References: <20240719-topic-t14s_upstream-v1-0-d7d97fdebb28@linaro.org> <20240719-topic-t14s_upstream-v1-3-d7d97fdebb28@linaro.org> <824edc08-f67f-4b2f-b4aa-da5df69b9df4@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <824edc08-f67f-4b2f-b4aa-da5df69b9df4@linaro.org> On 24-07-22 10:42:57, Konrad Dybcio wrote: > On 21.07.2024 6:40 PM, Abel Vesa wrote: > > On 24-07-19 22:16:38, Konrad Dybcio wrote: > >> Add support for the aforementioned laptop. That includes: > >> > >> - input methods, incl. lid switch (keyboard needs the pdc > >> wakeup-parent removal hack..) > >> - NVMe, WiFi > >> - USB-C ports > >> - GPU, display > >> - DSPs > >> > >> Notably, the USB-A ports on the side are depenedent on the USB > >> multiport controller making it upstream. > >> > >> At least one of the eDP panels used (non-touchscreen) identifies as > >> BOE 0x0b66. > >> > >> See below for the hardware description from the OEM. > >> > >> Link: https://www.lenovo.com/us/en/p/laptops/thinkpad/thinkpadt/lenovo-thinkpad-t14s-gen-6-(14-inch-snapdragon)/len101t0099 > >> Signed-off-by: Konrad Dybcio > > > > Few comments below. Otherwise, LGTM. > > > > Reviewed-by: Abel Vesa > > > >> --- > >> arch/arm64/boot/dts/qcom/Makefile | 1 + > >> .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 792 +++++++++++++++++++++ > >> 2 files changed, 793 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > >> index 0e5c810304fb..734a05e04c4a 100644 > >> --- a/arch/arm64/boot/dts/qcom/Makefile > >> +++ b/arch/arm64/boot/dts/qcom/Makefile > >> @@ -261,6 +261,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8650-hdk-display-card.dtb > >> dtb-$(CONFIG_ARCH_QCOM) += sm8650-hdk.dtb > >> dtb-$(CONFIG_ARCH_QCOM) += sm8650-mtp.dtb > >> dtb-$(CONFIG_ARCH_QCOM) += sm8650-qrd.dtb > >> +dtb-$(CONFIG_ARCH_QCOM) += x1e78100-lenovo-thinkpad-t14s.dtb > >> dtb-$(CONFIG_ARCH_QCOM) += x1e80100-asus-vivobook-s15.dtb > >> dtb-$(CONFIG_ARCH_QCOM) += x1e80100-crd.dtb > >> dtb-$(CONFIG_ARCH_QCOM) += x1e80100-lenovo-yoga-slim7x.dtb > >> diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts > > > > So what happens for SKUs of this model wil have x1e80100 ? > > > > Maybe we should stick to x1e80100 ? > > This one only ships with 78100 > Sure, but then in upstream we only have 80100. Plus, it is included in this file as well. I don't know what's the right thing to do here. But I think it keeps things more simple if we keep everything under the x1e80100 umbrella. > [...] > > >> + vreg_edp_3p3: regulator-edp-3p3 { > >> + compatible = "regulator-fixed"; > >> + > >> + regulator-name = "VREG_EDP_3P3"; > >> + regulator-min-microvolt = <3300000>; > >> + regulator-max-microvolt = <3300000>; > >> + > >> + gpio = <&tlmm 70 GPIO_ACTIVE_HIGH>; > >> + enable-active-high; > >> + > >> + pinctrl-0 = <&edp_reg_en>; > >> + pinctrl-names = "default"; > >> + > >> + regulator-always-on; > > > > Drop this. > > Oops! > > [...] > > >> + > >> + edp_reg_en: edp-reg-en-state { > >> + pins = "gpio70"; > >> + function = "gpio"; > >> + drive-strength = <16>; > >> + bias-pull-up; > > > > bias-disable, maybe ? > > Yeah, probably > > Konrad >