From: Boqun Feng <boqun.feng@gmail.com>
To: Z qiang <qiang.zhang1211@gmail.com>
Cc: paulmck@kernel.org,
syzbot <syzbot+784d0a1246a539975f05@syzkaller.appspotmail.com>,
frederic@kernel.org, jiangshanlai@gmail.com,
joel@joelfernandes.org, josh@joshtriplett.org,
linux-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com,
neeraj.upadhyay@kernel.org, rcu@vger.kernel.org,
rostedt@goodmis.org, syzkaller-bugs@googlegroups.com,
urezki@gmail.com
Subject: Re: [syzbot] [rcu?] WARNING in rcu_note_context_switch (2)
Date: Mon, 22 Jul 2024 10:55:33 -0700 [thread overview]
Message-ID: <Zp6dFQc6yyL3bqRa@boqun-archlinux> (raw)
In-Reply-To: <CALm+0cXx4LADq0XJeUP6M0KwY_ok9bx7YLOz1BSX09D3XrvUAQ@mail.gmail.com>
On Mon, Jul 22, 2024 at 02:42:10PM +0800, Z qiang wrote:
[...]
> > >
> > > This should be caused by this modification (commit id:
> > > ca567df74a28a9fb368c6b2d93e864113f73f5c2)
> > > when tsk is null, miss invoke rcu_read_unlock() for NS_GET_TGID_IN_PIDNS.
> >
> > Very good, and it looks like that to me as well. Would you like to
> > submit a fix patch and see if syzbot agrees?
>
> I see there is a c test
> program(https://syzkaller.appspot.com/x/repro.c?x=17a3c349980000),
> I will run this test on my local machine, and then make a fix.
>
FWIW, syzbot provides a way to do tests automatically:
https://github.com/google/syzkaller/blob/master/docs/syzbot.md#testing-patches
But looks like Christian already fixed this:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=280e36f0d5b997173d014c07484c03a7f7750668
Regards,
Boqun
> Thanks
> Zqiang
>
>
[...]
next prev parent reply other threads:[~2024-07-22 17:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-21 12:53 [syzbot] [rcu?] WARNING in rcu_note_context_switch (2) syzbot
2024-07-21 16:37 ` Paul E. McKenney
2024-07-22 3:38 ` Z qiang
2024-07-22 3:55 ` Paul E. McKenney
2024-07-22 6:42 ` Z qiang
2024-07-22 17:55 ` Boqun Feng [this message]
2024-07-23 13:44 ` Edward Adam Davis
2024-07-23 14:13 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zp6dFQc6yyL3bqRa@boqun-archlinux \
--to=boqun.feng@gmail.com \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=neeraj.upadhyay@kernel.org \
--cc=paulmck@kernel.org \
--cc=qiang.zhang1211@gmail.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=syzbot+784d0a1246a539975f05@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox