[PATCH v2] checkpatch: add "Reported-and-tested-by:" tag

[PATCH v2] checkpatch: add "Reported-and-tested-by:" tag

[Nam Cao]

The tag "Reported-and-tested-by:" is used all the time. Add this tag.

Signed-off-by: Nam Cao <namcao@linutronix.de>
---
v2: add missing colon

 scripts/checkpatch.pl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 9c4c4a61bc83..e2034da2aeb0 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -618,6 +618,7 @@ our $signature_tags = qr{(?xi:
 	Tested-by:|
 	Reviewed-by:|
 	Reported-by:|
+	Reported-and-tested-by:|
 	Suggested-by:|
 	To:|
 	Cc:
@@ -712,7 +713,7 @@ sub find_standard_signature {
 	my ($sign_off) = @_;
 	my @standard_signature_tags = (
 		'Signed-off-by:', 'Co-developed-by:', 'Acked-by:', 'Tested-by:',
-		'Reviewed-by:', 'Reported-by:', 'Suggested-by:'
+		'Reviewed-by:', 'Reported-by:', 'Suggested-by:', 'Reported-and-tested-by:'
 	);
 	foreach my $signature (@standard_signature_tags) {
 		return $signature if (get_edit_distance($sign_off, $signature) <= 2);
-- 
2.39.2

Re: [PATCH v2] checkpatch: add "Reported-and-tested-by:" tag

[Joe Perches]

On Sat, 2024-04-20 at 00:28 +0200, Nam Cao wrote:
> The tag "Reported-and-tested-by:" is used all the time. Add this tag.

General nack:

I think that combined tags should be avoided

see:

Documentation/process/maintainer-tip.rst:Please do not use combined tags, e.g. ``Reported-and-tested-by``, as
Documentation/process/maintainer-tip.rst-they just complicate automated extraction of tags.

Re: [PATCH v2] checkpatch: add "Reported-and-tested-by:" tag

[Carlos Llamas]

On Sat, Apr 20, 2024 at 09:22:45AM -0700, Joe Perches wrote:
> On Sat, 2024-04-20 at 00:28 +0200, Nam Cao wrote:
> > The tag "Reported-and-tested-by:" is used all the time. Add this tag.
> 
> General nack:
> 
> I think that combined tags should be avoided
> 
> see:
> 
> Documentation/process/maintainer-tip.rst:Please do not use combined tags, e.g. ``Reported-and-tested-by``, as
> Documentation/process/maintainer-tip.rst-they just complicate automated extraction of tags.
> 

If combined tags are discouraged then syzbot should perhaps stop
suggesting the `Reported-and-tested-by:` tag? I would imagine this not
only applies to the tip tree and that other maintainers agree with not
using combined tags.

FWIW, this tag in particular though is quite popular:
$ git log --grep '^Reported-and-tested-by: ' origin/master |wc -l
82056

--
Carlos Llamas

Re: [PATCH v2] checkpatch: add "Reported-and-tested-by:" tag

[Dmitry Vyukov]

On Tue, 16 Jul 2024 at 07:24, Carlos Llamas <cmllamas@google.com> wrote:
>
> On Sat, Apr 20, 2024 at 09:22:45AM -0700, Joe Perches wrote:
> > On Sat, 2024-04-20 at 00:28 +0200, Nam Cao wrote:
> > > The tag "Reported-and-tested-by:" is used all the time. Add this tag.
> >
> > General nack:
> >
> > I think that combined tags should be avoided
> >
> > see:
> >
> > Documentation/process/maintainer-tip.rst:Please do not use combined tags, e.g. ``Reported-and-tested-by``, as
> > Documentation/process/maintainer-tip.rst-they just complicate automated extraction of tags.
> >
>
> If combined tags are discouraged then syzbot should perhaps stop
> suggesting the `Reported-and-tested-by:` tag? I would imagine this not
> only applies to the tip tree and that other maintainers agree with not
> using combined tags.
>
> FWIW, this tag in particular though is quite popular:
> $ git log --grep '^Reported-and-tested-by: ' origin/master |wc -l
> 82056

+syzkaller mailing list

We can add whatever text you will say. What is the official position?

Re: [PATCH v2] checkpatch: add "Reported-and-tested-by:" tag

[Carlos Llamas]

On Tue, Jul 16, 2024 at 09:11:08AM +0200, Dmitry Vyukov wrote:
> On Tue, 16 Jul 2024 at 07:24, Carlos Llamas <cmllamas@google.com> wrote:
> >
> > If combined tags are discouraged then syzbot should perhaps stop
> > suggesting the `Reported-and-tested-by:` tag? I would imagine this not
> > only applies to the tip tree and that other maintainers agree with not
> > using combined tags.
> >
> > FWIW, this tag in particular though is quite popular:
> > $ git log --grep '^Reported-and-tested-by: ' origin/master |wc -l
> > 82056

The number of patches with this tag is actually 2689. Sorry, I forgot to
add the --oneline option to my initial query.

> 
> +syzkaller mailing list
> 
> We can add whatever text you will say. What is the official position?

I don't know if there is an official position but IMO individual tags
are the safest option. This would even allow tools such as b4 to collect
the tags automatically. So splitting out 'Reported-and-tested-by:' seems
trivial enough?

  Reported-by: syzbot+<context>
  Tested-by: syzbot+<context>

Re: [PATCH v2] checkpatch: add "Reported-and-tested-by:" tag

[Dmitry Vyukov]

On Wed, 17 Jul 2024 at 00:44, Carlos Llamas <cmllamas@google.com> wrote:
>
> On Tue, Jul 16, 2024 at 09:11:08AM +0200, Dmitry Vyukov wrote:
> > On Tue, 16 Jul 2024 at 07:24, Carlos Llamas <cmllamas@google.com> wrote:
> > >
> > > If combined tags are discouraged then syzbot should perhaps stop
> > > suggesting the `Reported-and-tested-by:` tag? I would imagine this not
> > > only applies to the tip tree and that other maintainers agree with not
> > > using combined tags.
> > >
> > > FWIW, this tag in particular though is quite popular:
> > > $ git log --grep '^Reported-and-tested-by: ' origin/master |wc -l
> > > 82056
>
> The number of patches with this tag is actually 2689. Sorry, I forgot to
> add the --oneline option to my initial query.
>
> >
> > +syzkaller mailing list
> >
> > We can add whatever text you will say. What is the official position?
>
> I don't know if there is an official position but IMO individual tags
> are the safest option. This would even allow tools such as b4 to collect
> the tags automatically. So splitting out 'Reported-and-tested-by:' seems
> trivial enough?
>
>   Reported-by: syzbot+<context>
>   Tested-by: syzbot+<context>

I've sent https://github.com/google/syzkaller/pull/5060/files
to split the tag into 2 in syzbot emails.