From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8786AB641 for ; Tue, 16 Jul 2024 15:38:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721144322; cv=none; b=JnNJNyKlYcYo6fbTWyW2nuw9BUXmIpoVFR4f2P6R2GRd8bJ6tjIzEnP4fBwSZPxRnTNNhUBxCFwDN8dlJpfmabQVeX1yvERGkji+Q0atL4ME2k6rMJOhtF9wQQgxvztQGEweWEmmmyX29sndmvxIAbadZJhmCzYBe0dHX0H7gzo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721144322; c=relaxed/simple; bh=wFRmeqZAChY0vBaEki4uMRrWLGdelkkOLKoOuO9tiyI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V0GMgwsc3ln1ToRsLmP+EDYsI7UO5lQ//TK/OwlRbU90GSPIsPw9qM7UNaC4UOOirfIrzpmCGreXIHiLHGdjQe1iWig2fMzVRe3gONtIUmc9Y1oYsThg/cDB6JSkY0+FrlgQhJmNHBxTXEQKTUOhGwet4K180es8IRinFwSSYi4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gZoYQahl; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gZoYQahl" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-7515437ff16so4080190a12.2 for ; Tue, 16 Jul 2024 08:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721144320; x=1721749120; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IRJWJNrzc2jygwsryIDGVRubrMYo6CPq74PglfU61vc=; b=gZoYQahlP1Z+jz6OPl3Il9H5oJSx258hT1An6uOzq8UdskDfJy2+sHt5+ALoDL+SeB U1rdRwxfpV1KT1jEfpDirCSPJebRsYAYduas6Cv1gJghNlzqy+R50g2cYuTZIKgLVEiz DRo5ThFLP7PV8xLBTDXTQNDhD0K8JtQPKJtQTkQx4wX5ioGNfqxzD5htlQ2Iibpm0FzT Y5Y4k3m/2z14AnkbRR+2lBbiEzYIw6k4tNTxzWqZPqs8sy8WJQMEPnghYWw/Ps8u8WyU 7H7Xbr3c7h/nfYQav5uF3/hQtDOH3LeUoZ12U403MuOQrXzBw3yIzQIB2woJc99teslH zZhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721144320; x=1721749120; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IRJWJNrzc2jygwsryIDGVRubrMYo6CPq74PglfU61vc=; b=fNeZJXIIBGQcSq0paD9orpVDcqQo6F4jiRlegH0gVgNVTzle/ZdkkUxTnBn/VHJb81 ljkMi4203UV4h6iuu6eCtCbcizCLKU72Bcqzjxwz0h2k11BklBgSetynTchZ4E8ajPek 2DQ/o72piSIhVodhFNRlJAvZI6c7X7jCLSBCQkglwNhgJwIvaBGReMuhM3W2KOiMJJx2 ysN23Ep1x54n8/ppfOxoI2B5bJ7MfCH/VkgqVb0reyneBvKWUUww7mbMPioB1bwy7FYb MHNA60ltrqHnsRCL8T8/fq0z8RXduprzgRC4uPcGnPHWxaBO9zSzmNlA+oRt1CrTuNZW jKYA== X-Forwarded-Encrypted: i=1; AJvYcCXckIE7FbKqnmKHShXu4k3AFq3s0+ozOLbBhiFm3aaHrDbUI1ceCZtsFXrqxjGZAB8atLaSuj2iR+OIyaKmD2brj2rGgKoxLJV5l3Ph X-Gm-Message-State: AOJu0Yxwx5DPnqH66tXtKqOP84xNvo3bJwx9rFfyNlY41kVcO30A0P/w QamRF1Yi5nVfNMIQ87wP4q0HoEpUEgMT31s/ozIuEBCUrokQcC5SW0KL9Bn4TME= X-Google-Smtp-Source: AGHT+IEDSWIUtRywATQg3qAhHcdwjWZgT7tZwoG/YQpCa+cTCsrStW9SpatZa0yN+LXWMK82f6rs3Q== X-Received: by 2002:a05:6a20:3d8c:b0:1c0:f097:4eb8 with SMTP id adf61e73a8af0-1c3f1273b1emr3243135637.35.1721144319905; Tue, 16 Jul 2024 08:38:39 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:5d01:167d:9cf4:148e]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cacd3f10dfsm8466569a91.17.2024.07.16.08.38.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 08:38:39 -0700 (PDT) Date: Tue, 16 Jul 2024 09:38:36 -0600 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Richard Zhu , linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH 3/6] remoteproc: imx_rproc: initialize workqueue earlier Message-ID: References: <20240712-imx_rproc-v1-0-7bcf6732d328@nxp.com> <20240712-imx_rproc-v1-3-7bcf6732d328@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240712-imx_rproc-v1-3-7bcf6732d328@nxp.com> On Fri, Jul 12, 2024 at 04:34:56PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Initialize workqueue before requesting mailbox channel, otherwise if > mailbox interrupt comes before workqueue ready, the imx_rproc_rx_callback > will trigger issue. > > Reviewed-by: Richard Zhu All reviews should be done publicly - please remove here and for all the other patches. > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 48c48b53a3aa..9e99bb27c033 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -1087,6 +1087,8 @@ static int imx_rproc_probe(struct platform_device *pdev) > return -ENOMEM; > } > > + INIT_WORK(&priv->rproc_work, imx_rproc_vq_work); > + There should be a "Fixes:" tag on this patch. > ret = imx_rproc_xtr_mbox_init(rproc); > if (ret) > goto err_put_wkq; > @@ -1105,8 +1107,6 @@ static int imx_rproc_probe(struct platform_device *pdev) > if (ret) > goto err_put_scu; > > - INIT_WORK(&priv->rproc_work, imx_rproc_vq_work); > - > if (rproc->state != RPROC_DETACHED) > rproc->auto_boot = of_property_read_bool(np, "fsl,auto-boot"); > > > -- > 2.37.1 >