From: Johan Hovold <johan@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hansverk@cisco.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Milen Mitkov <quic_mmitkov@quicinc.com>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Johan Hovold <johan+linaro@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] media: qcom: camss: Remove use_count guard in stop_streaming
Date: Wed, 17 Jul 2024 13:04:34 +0200 [thread overview]
Message-ID: <ZpelQj6HufZTe52d@hovoldconsulting.com> (raw)
In-Reply-To: <2d8ac288-da60-490a-a6ac-ebe524e3fc21@linaro.org>
On Wed, Jul 17, 2024 at 11:43:02AM +0100, Bryan O'Donoghue wrote:
> On 17/07/2024 10:06, Johan Hovold wrote:
> >> The use of use_count like this is a bit hacky and right now breaks regular
> >> usage of CAMSS for a single stream case. As an example the "qcam"
> >> application in libcamera will fail with an -EBUSY result on stream stop and
> >> cannot then subsequently be restarted.
> > No, stopping qcam results in the splat below, and then it cannot be
> > started again and any attempts to do so fails with -EBUSY.
>
> I thought that's what I said.
I read the above as if stopping the stream fails with -EBUSY, when it's
really restarting the stream that fails that way after the first stop.
> Let me reword the commit log with your sentence included directly :)
Sounds good.
Johan
next prev parent reply other threads:[~2024-07-17 11:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 22:13 [PATCH v2 0/2] media: qcom: camss: Fix two CAMSS bugs found by dogfooding with SoftISP Bryan O'Donoghue
2024-07-16 22:13 ` [PATCH v2 1/2] media: qcom: camss: Remove use_count guard in stop_streaming Bryan O'Donoghue
2024-07-17 9:06 ` Johan Hovold
2024-07-17 10:43 ` Bryan O'Donoghue
2024-07-17 11:04 ` Johan Hovold [this message]
2024-07-16 22:13 ` [PATCH v2 2/2] media: qcom: camss: Fix ordering of pm_runtime_enable Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpelQj6HufZTe52d@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=hansverk@cisco.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=johan+linaro@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_mmitkov@quicinc.com \
--cc=rfoss@kernel.org \
--cc=stable@vger.kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox