Re: [PATCH v2 2/2] wifi: mwifiex: add support for WPA-PSK-SHA256

Francesco Dolcini
2024-07-22T10:57:03Z

On Mon, Jul 22, 2024 at 09:48:59AM +0200, Sascha Hauer wrote:
> On Fri, Jul 19, 2024 at 12:05:01PM -0700, Brian Norris wrote:
> > On Fri, Jul 19, 2024 at 08:04:59AM +0200, Sascha Hauer wrote:
> > > I could change setting the key_mgmt bits to |= as it feels more natural
> > > and raises less eyebrows, but in my testing it didn't make a difference.
> Thinking about this again we really do need to use '|=' and not '='
> to make the result independent of the ordering of the AKM suites array
> entries.

Yes, absolutely. I missed this while looking at your changes.

Francesco