Re: [PATCH v2 1/2] wifi: mwifiex: simplify WPA flags setting

Brian Norris
2024-07-18T22:40:25Z

On Wed, Jul 17, 2024 at 10:30:07AM +0200, Sascha Hauer wrote:
> The WPA flags setting only depends on the wpa_versions bitfield and not
> on the AKM suite, so move it out of the switch/case to simplify the code
> a bit. Also set bss_config->protocol to zero explicitly. This is done
> only to make the code clearer, bss_config has been zero alloced by the
> caller, so should be zero already. No functional change intended.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/net/wireless/marvell/mwifiex/uap_cmd.c | 28 ++++++++------------------
> 1 file changed, 8 insertions(+), 20 deletions(-)

Acked-by: Brian Norris <briannorris@chromium.org>