Re: [PATCH v3 1/2] rust: kernel: add `drop_contents` to `BoxExt`

Benno Lossin
2024-08-03T14:23:48Z

On 03.08.24 16:16, Benno Lossin wrote:
> @@ -53,4 +69,12 @@ fn new_uninit(flags: Flags) -> Result<Box<MaybeUninit<T>>, AllocError> {
> // zero-sized types, we use `NonNull::dangling`.
> Ok(unsafe { Box::from_raw(ptr) })
> }
> +
> + fn drop_contents(this: Self) -> Box<MaybeUninit<T>> {
> + let ptr = Box::into_raw(this);
> + // SAFETY: `ptr` is valid, because it came from `Box::into_raw`.
> + unsafe { ptr::drop_in_place(ptr) };
> + // SAFETY: `ptr` is valid, because it came from `Box::into_raw`.

I just noticed that I missed another comment from Boqun here. Got
confused with the two mails. I would replace the comment above with

// CAST: `T` and `MaybeUninit<T>` have the same layout.
let ptr = ptr.cast::<MaybeUninit<T>>();
// SAFETY: `ptr` is valid for writes, because it came from `Box::into_raw` and it is valid for
// reads, since the pointer came from `Box::into_raw` and the type is `MaybeUninit<T>`.

Let me know if you want another version.

---
Cheers,
Benno

> + unsafe { Box::from_raw(ptr.cast()) }
> + }
> }
> --
> 2.45.2
>
>
>