From: Christoph Hellwig <hch@infradead.org>
To: Dongliang Cui <dongliang.cui@unisoc.com>
Cc: linkinjeon@kernel.org, sj1557.seo@samsung.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
niuzhiguo84@gmail.com, hao_hao.wang@unisoc.com,
ke.wang@unisoc.com, cuidongliang390@gmail.com,
Zhiguo Niu <zhiguo.niu@unisoc.com>
Subject: Re: [PATCH v2] exfat: check disk status during buffer write
Date: Wed, 24 Jul 2024 06:07:01 -0700 [thread overview]
Message-ID: <ZqD8dWFG5uxmJ6yn@infradead.org> (raw)
In-Reply-To: <20240723105412.3615926-1-dongliang.cui@unisoc.com>
> +static int exfat_block_device_ejected(struct super_block *sb)
> +{
> + struct backing_dev_info *bdi = sb->s_bdi;
> +
> + return bdi->dev == NULL;
> +}
NAK, file systems have no business looking at this. What you probably
really want is to implement the ->shutdown method for exfat so it gets
called on device removal.
next prev parent reply other threads:[~2024-07-24 13:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240723105423epcas1p4d4ee53975fbc4644e969b5c9b7514c9b@epcas1p4.samsung.com>
2024-07-23 10:54 ` [PATCH v2] exfat: check disk status during buffer write Dongliang Cui
2024-07-24 7:03 ` Sungjong Seo
2024-07-24 7:24 ` dongliang cui
2024-07-24 7:50 ` Sungjong Seo
2024-07-24 8:27 ` dongliang cui
2024-07-24 13:07 ` Christoph Hellwig [this message]
2024-07-25 6:00 ` Sungjong Seo
2024-07-26 6:18 ` dongliang cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqD8dWFG5uxmJ6yn@infradead.org \
--to=hch@infradead.org \
--cc=cuidongliang390@gmail.com \
--cc=dongliang.cui@unisoc.com \
--cc=hao_hao.wang@unisoc.com \
--cc=ke.wang@unisoc.com \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niuzhiguo84@gmail.com \
--cc=sj1557.seo@samsung.com \
--cc=zhiguo.niu@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox