Re: [bug report] iommu/arm-smmu-v3: Event cannot be printed in some scenarios

Jason Gunthorpe
2024-08-13T17:57:00Z

On Thu, Aug 08, 2024 at 01:50:17PM +0000, Pranjal Shrivastava wrote:
>
> Kunkun -- Please try this diff and check if it fixes the problem?

This looks OK to me, you should send it as a proper patch..

> if (!(fault->prm.flags & IOMMU_FAULT_PAGE_REQUEST_LAST_PAGE)) {
> - report_partial_fault(iopf_param, fault);
> + ret = report_partial_fault(iopf_param, fault);
> iopf_put_dev_fault_param(iopf_param);
> /* A request that is not the last does not need to be ack'd */
> +
> + if (ret)
> + goto err_bad_iopf;
> }

rebase it on -rc3 and there will be a return line added here
too.. Maybe you don't want the goto in that cast

Jason