From: Herbert Xu <herbert@gondor.apana.org.au>
To: Greg KH <gregkh@linuxfoundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: stsp <stsp2@yandex.ru>,
linux-serial@vger.kernel.org,
Linux kernel <linux-kernel@vger.kernel.org>,
Johan Hovold <johan@kernel.org>
Subject: Re: [regression] ENOTTY returned for tty fds
Date: Wed, 24 Jul 2024 18:53:00 +0800 [thread overview]
Message-ID: <ZqDdDPF_N9tcbu_S@gondor.apana.org.au> (raw)
In-Reply-To: <2024072401-obtain-heap-6d8d@gregkh>
On Wed, Jul 24, 2024 at 12:15:39PM +0200, Greg KH wrote:
>
> -ENOTTY is the documented result of invalid ioctl arguments sent, I am
> pretty sure POSIX requires this somewhere. So this was fixing a
> requirement here...
POSIX does not specify this at all:
https://pubs.opengroup.org/onlinepubs/9699919799/functions/ioctl.html
I think this should be reverted as it breaks user-space code
that dates back to 2003.
ENOTTY doesn't even make sense anyway as it literally means "is not a
terminal" and pseudo-ttys certainly are terminals.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2024-07-24 11:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <b6f4aa5c-10ba-411b-994b-6dbed2bf63db@yandex.ru>
[not found] ` <2024072452-pegboard-undying-4245@gregkh>
2024-07-24 8:07 ` [regression] ENOTTY returned for tty fds stsp
2024-07-24 9:08 ` Greg KH
2024-07-24 9:55 ` stsp
2024-07-24 10:15 ` Greg KH
2024-07-24 10:53 ` Herbert Xu [this message]
2024-07-24 10:58 ` Herbert Xu
2024-07-31 10:25 ` Greg KH
2024-07-31 16:12 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqDdDPF_N9tcbu_S@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=stsp2@yandex.ru \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox