From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4EB58134DE; Wed, 24 Jul 2024 14:26:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721831188; cv=none; b=RQyQYXmOSm/+LG6e1kLCFN/Jt4p4y2iUUu8m7MYq3eEWO1cAUEEQfeysN5cjkJsw/SmkPv5jSQVui/SyN0I3H2Q6dUs2UzHzQPYB6F/Ac8N+QgXG05WhHve5W1R52zDFSpU7wFoWsm40u3Fi0hsjPkUpy6TvE8GRpciSiRTtC/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721831188; c=relaxed/simple; bh=0bBgnN3OSeuH8VO3vOvXoPT/9tsQofX1W71MvQG1L+0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Zf3czZv6As1BFoUzHZWV0Q5r2+wasE1FDvrUqaFvYoXKjmR6lQ2m7sSlmJ/dlKwOgZNkB99jDzFMJVcQdfCUAeh0aspRRh9ub29Ypkip+ADFTQfJH+XJy3wMutOeF73LPysB0MiYdnSC3jO8PQrb0XD4IQ4DZRYxKFDvO0+GSTE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E53E8106F; Wed, 24 Jul 2024 07:26:50 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1C0743F5A1; Wed, 24 Jul 2024 07:26:23 -0700 (PDT) Date: Wed, 24 Jul 2024 15:26:21 +0100 From: Cristian Marussi To: Luke Parkin Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, sudeep.holla@arm.com, cristian.marussi@arm.com Subject: Re: [PATCH v3 4/5] firmware: arm_scmi: Create debugfs files for statistics Message-ID: References: <20240715133751.2877197-1-luke.parkin@arm.com> <20240715133751.2877197-5-luke.parkin@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240715133751.2877197-5-luke.parkin@arm.com> On Mon, Jul 15, 2024 at 02:37:50PM +0100, Luke Parkin wrote: > Create debugfs files for the statistics in the scmi_debug_stats struct > > Signed-off-by: Luke Parkin Here you missed the seprator --- before the changelog...so this will go into the final commit. Thanks, Cristian > v2->v3 > Add extra statistics also added in v3 > v1->v2 > Only create stats pointer if stats are enabled > Move stats debugfs creation into a seperate helper function > --- > drivers/firmware/arm_scmi/driver.c | 38 ++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index b22f104cda36..9378e2d8af4f 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -2865,6 +2865,41 @@ static int scmi_device_request_notifier(struct notifier_block *nb, > return NOTIFY_OK; > } > > +static void scmi_debugfs_stats_setup(struct scmi_info *info, > + struct dentry *trans) > +{ > + struct dentry *stats; > + > + stats = debugfs_create_dir("stats", trans); > + > + debugfs_create_atomic_t("sent_ok", 0400, stats, > + &info->dbg_stats[SENT_OK]); > + debugfs_create_atomic_t("sent_fail", 0400, stats, > + &info->dbg_stats[SENT_FAIL]); > + debugfs_create_atomic_t("sent_fail_polling_unsupported", 0400, stats, > + &info->dbg_stats[SENT_FAIL_POLLING_UNSUPPORTED]); > + debugfs_create_atomic_t("sent_fail_channel_not_found", 0400, stats, > + &info->dbg_stats[SENT_FAIL_CHANNEL_NOT_FOUND]); > + debugfs_create_atomic_t("response_ok", 0400, stats, > + &info->dbg_stats[RESPONSE_OK]); > + debugfs_create_atomic_t("notif_ok", 0400, stats, > + &info->dbg_stats[NOTIF_OK]); > + debugfs_create_atomic_t("dlyd_resp_ok", 0400, stats, > + &info->dbg_stats[DLYD_RESPONSE_OK]); > + debugfs_create_atomic_t("xfers_resp_timeout", 0400, stats, > + &info->dbg_stats[XFERS_RESPONSE_TIMEOUT]); > + debugfs_create_atomic_t("response_polled_ok", 0400, stats, > + &info->dbg_stats[RESPONSE_POLLED_OK]); > + debugfs_create_atomic_t("err_msg_unexpected", 0400, stats, > + &info->dbg_stats[ERR_MSG_UNEXPECTED]); > + debugfs_create_atomic_t("err_msg_invalid", 0400, stats, > + &info->dbg_stats[ERR_MSG_INVALID]); > + debugfs_create_atomic_t("err_msg_nomem", 0400, stats, > + &info->dbg_stats[ERR_MSG_NOMEM]); > + debugfs_create_atomic_t("err_protocol", 0400, stats, > + &info->dbg_stats[ERR_PROTOCOL]); > +} > + > static void scmi_debugfs_common_cleanup(void *d) > { > struct scmi_debug_info *dbg = d; > @@ -2931,6 +2966,9 @@ static struct scmi_debug_info *scmi_debugfs_common_setup(struct scmi_info *info) > debugfs_create_u32("rx_max_msg", 0400, trans, > (u32 *)&info->rx_minfo.max_msg); > > + if (IS_ENABLED(CONFIG_ARM_SCMI_DEBUG_STATISTICS)) > + scmi_debugfs_stats_setup(info, trans); > + > dbg->top_dentry = top_dentry; > > if (devm_add_action_or_reset(info->dev, > -- > 2.34.1 > >