Re: [PATCH v3 0/5] Add Per-transport SCMI debug statistics

Cristian Marussi
2024-07-24T14:46:10Z

On Mon, Jul 15, 2024 at 02:37:46PM +0100, Luke Parkin wrote:
> This series adds support for tracking Arm SCMI statistics [Patch 2/3]
> A config option to enable this [Patch 2]
> Cleans up a unneeded call to handle_scmi_info [Patch 1]
> In [Patch 4] a selection of new debugfs entries to present these statistics
> Then finally in [Patch 5] enabled writing on the debugfs entries to reset stats
>
> Based on v6.9, Tested on Arm Juno [1]
>
> Thanks,
> Luke

Beside the specific patch review comments, I have been just reminded by
ATG that using SCMI stats is a bit ambigous since there are statistics
in the protocol...so please in v4 take care to rename all the
code/commmemts and commit msg to something else ... that could be...
"counters" ? instead of stats...so you will have debug counters available
under transport/counters instead of /stats....etc etc

Thanks,
Cristian